Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1616673005: Revert "Fix-up a wrong hit testing when a parent inline has border radius." (Closed)

Created:
4 years, 11 months ago by skobes
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, esprehn, jchaffraix+rendering, leviw+renderwatch, Miyoung Shin(c), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Fix-up a wrong hit testing when a parent inline has border radius." This change broke hit testing in Gmail chat moles. (Implicated by bisect and confirmed by local repro.) This reverts commit http://crrev.com/369971. BUG=579741 Committed: https://crrev.com/b4c34a17e5598149a2216606201c301a91b6ba32 Cr-Commit-Position: refs/heads/master@{#370893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -39 lines) Patch
D third_party/WebKit/LayoutTests/fast/inline-block/hittest-child-of-inlineblock.html View 1 chunk +0 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.cpp View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
skobes
4 years, 11 months ago (2016-01-22 02:18:46 UTC) #7
pdr.
+cc myid.shin LGTM
4 years, 11 months ago (2016-01-22 02:20:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616673005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616673005/1
4 years, 11 months ago (2016-01-22 02:21:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 03:35:08 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 03:36:39 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4c34a17e5598149a2216606201c301a91b6ba32
Cr-Commit-Position: refs/heads/master@{#370893}

Powered by Google App Engine
This is Rietveld 408576698