Merge x86 data and header lowering

Merge x86 data and header lowering

BUG=
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6b80cf109e33aaf58de116b63a0562227d096429

[sehr, 2016-01-21 22:45:18]

Description was changed from

==========
Merge data lowering

BUG=
==========

to

==========
Merge x86 data and header lowering

BUG=
==========

[sehr, 2016-01-21 22:45:18]

sehr@chromium.org changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@chromium.org,
stichnot@chromium.org

[sehr, 2016-01-21 22:45:41]

Last of the common code in x86 merged together.

[Jim Stichnoth, 2016-01-22 05:52:11]

lgtm

https://codereview.chromium.org/1616673004/diff/60001/src/IceTargetLoweringX8...
File src/IceTargetLoweringX86.cpp (right):

https://codereview.chromium.org/1616673004/diff/60001/src/IceTargetLoweringX8...
src/IceTargetLoweringX86.cpp:1: //===- subzero/src/IceTargetLoweringX86.cpp -
x86 lowering -*- C++ -*-==//
Add hyphens near the end (and maybe make it a triple-equals like the rest) to
add up to 80 columns.

https://codereview.chromium.org/1616673004/diff/60001/src/IceTargetLoweringX8...
File src/IceTargetLoweringX86BaseImpl.h (right):

https://codereview.chromium.org/1616673004/diff/60001/src/IceTargetLoweringX8...
src/IceTargetLoweringX86BaseImpl.h:7343: assert(CharsPrinted >= 0 &&
This is better split into two separate asserts.

https://codereview.chromium.org/1616673004/diff/60001/src/IceTargetLoweringX8...
src/IceTargetLoweringX86BaseImpl.h:7356: // No need to emit constants from the
int pool since (for x86) they are
This comment seems wrong and should probably be deleted.

It was probably true before the implementation of constant pooling for the code
diversification project.

[sehr, 2016-01-22 07:06:24]

Thanks for the review.   Testing...

https://codereview.chromium.org/1616673004/diff/60001/src/IceTargetLoweringX8...
File src/IceTargetLoweringX86.cpp (right):

https://codereview.chromium.org/1616673004/diff/60001/src/IceTargetLoweringX8...
src/IceTargetLoweringX86.cpp:1: //===- subzero/src/IceTargetLoweringX86.cpp -
x86 lowering -*- C++ -*-==//
On 2016/01/22 05:52:10, stichnot wrote:
> Add hyphens near the end (and maybe make it a triple-equals like the rest) to
> add up to 80 columns.

Done.

https://codereview.chromium.org/1616673004/diff/60001/src/IceTargetLoweringX8...
File src/IceTargetLoweringX86BaseImpl.h (right):

https://codereview.chromium.org/1616673004/diff/60001/src/IceTargetLoweringX8...
src/IceTargetLoweringX86BaseImpl.h:7343: assert(CharsPrinted >= 0 &&
On 2016/01/22 05:52:10, stichnot wrote:
> This is better split into two separate asserts.

Done.

https://codereview.chromium.org/1616673004/diff/60001/src/IceTargetLoweringX8...
src/IceTargetLoweringX86BaseImpl.h:7356: // No need to emit constants from the
int pool since (for x86) they are
On 2016/01/22 05:52:10, stichnot wrote:
> This comment seems wrong and should probably be deleted.
> 
> It was probably true before the implementation of constant pooling for the
code
> diversification project.

Deleted.

[sehr, 2016-01-22 07:17:01]

Description was changed from

==========
Merge x86 data and header lowering

BUG=
==========

to

==========
Merge x86 data and header lowering

BUG=
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[sehr, 2016-01-22 07:17:02]

Committed patchset #4 (id:60001) manually as
6b80cf109e33aaf58de116b63a0562227d096429 (presubmit successful).