Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1616673002: dart2js cps: Debugging utility and fix idempotency in shrinking reducer. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Debugging utility and fix idempotency in shrinking reducer. Shrinking reductions would miss some redexes that were created during a reduction. It now finds more redexes and has a self-checking mode that can be enabled when working on the pass. Also adds some general debugging utility functions to the CPS IR. The root class Node now has "debugString" and "debugPrint" methods for conveniently getting its SExpression. The CpsFunctionCompiler now has a method "debugCpsPass" which runs a CPS pass while checking that it is idempotent for that input. Most passes are not yet idempotent, but this utility should help us get there. BUG= Committed: https://github.com/dart-lang/sdk/commit/6c9a7ec96717666b50a669c84502f29bb5496896

Patch Set 1 #

Patch Set 2 : Compute before string after shrinking reducer #

Patch Set 3 : Clean up and minor speed improvements in shrinking reductions #

Patch Set 4 : Merge #

Patch Set 5 : Do not run the same Pass instance twice #

Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -162 lines) Patch
M pkg/compiler/lib/src/cps_ir/backward_null_check_remover.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 2 3 7 chunks +61 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 2 3 2 chunks +46 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 1 2 3 3 chunks +9 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/redundant_join.dart View 4 chunks +10 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 1 2 3 20 chunks +209 lines, -131 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 2 3 4 2 chunks +44 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
asgerf
4 years, 11 months ago (2016-01-21 04:18:15 UTC) #4
Kevin Millikin (Google)
LVGTM.
4 years, 11 months ago (2016-01-26 08:40:40 UTC) #5
asgerf
4 years, 11 months ago (2016-01-26 15:37:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
6c9a7ec96717666b50a669c84502f29bb5496896 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698