Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1616663003: Fix bounds computations for SkDisplacementMapEffect with negative scale. (Closed)

Created:
4 years, 11 months ago by Stephen White
Modified:
4 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add test case to GM #

Patch Set 3 : Use clipped bitmap for test case #

Patch Set 4 : Fix oops #

Patch Set 5 : fix onComputeFastBounds() as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M gm/displacement.cpp View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616663003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616663003/60001
4 years, 11 months ago (2016-01-21 15:22:08 UTC) #3
Stephen White
Rob: PTAL. Thanks!
4 years, 11 months ago (2016-01-21 15:23:11 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-21 15:36:05 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616663003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616663003/80001
4 years, 11 months ago (2016-01-21 15:59:05 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-21 16:15:13 UTC) #12
robertphillips
lgtm
4 years, 11 months ago (2016-01-21 17:50:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616663003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616663003/80001
4 years, 11 months ago (2016-01-21 17:55:11 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 17:55:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/00502373c8d38b091fe1b9ba15b8510bcc0375bc

Powered by Google App Engine
This is Rietveld 408576698