Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: third_party/WebKit/Source/core/animation/CompositorAnimationsTestHelper.h

Issue 1616653002: CC Animation: Move files from cc_blink to Source/platform/animation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update GN. Port CompositorAnimationsTest to use CompositorFactoryMock. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/CompositorAnimationsTestHelper.h
diff --git a/third_party/WebKit/Source/core/animation/CompositorAnimationsTestHelper.h b/third_party/WebKit/Source/core/animation/CompositorAnimationsTestHelper.h
index 687fa04ed948ab29c0e8d98aa555cbcd84ebf3e5..799052a45ff4b72a6a972b4497bb28ed15e70303 100644
--- a/third_party/WebKit/Source/core/animation/CompositorAnimationsTestHelper.h
+++ b/third_party/WebKit/Source/core/animation/CompositorAnimationsTestHelper.h
@@ -26,12 +26,13 @@
#define CompositorAnimationsTestHelper_h
#include "core/animation/CompositorAnimations.h"
+#include "platform/CompositorFactory.h"
+#include "platform/animation/WebFloatAnimationCurve.h"
+#include "platform/animation/WebFloatKeyframe.h"
#include "platform/testing/TestingPlatformSupport.h"
#include "public/platform/WebCompositorAnimationPlayer.h"
#include "public/platform/WebCompositorAnimationTimeline.h"
#include "public/platform/WebCompositorSupport.h"
-#include "public/platform/WebFloatAnimationCurve.h"
-#include "public/platform/WebFloatKeyframe.h"
#include "wtf/PassOwnPtr.h"
#include <gmock/gmock.h>
@@ -110,7 +111,7 @@ public:
virtual WebCompositorAnimationCurve::AnimationCurveType type() const { return CurveId; }
MOCK_METHOD0(delete_, void());
- ~WebCompositorAnimationCurveMock() { delete_(); }
+ ~WebCompositorAnimationCurveMock() override { delete_(); }
};
using WebFloatAnimationCurveMock = WebCompositorAnimationCurveMock<WebFloatAnimationCurve, WebCompositorAnimationCurve::AnimationCurveTypeFloat, WebFloatKeyframe>;
@@ -145,12 +146,15 @@ public:
class WebCompositorSupportMock : public WebCompositorSupport {
public:
MOCK_METHOD4(createAnimation, WebCompositorAnimation*(const WebCompositorAnimationCurve& curve, WebCompositorAnimation::TargetProperty target, int groupId, int animationId));
- MOCK_METHOD0(createFloatAnimationCurve, WebFloatAnimationCurve*());
-
MOCK_METHOD0(createAnimationPlayer, WebCompositorAnimationPlayer*());
MOCK_METHOD0(createAnimationTimeline, WebCompositorAnimationTimeline*());
};
+ class CompositorFactoryMock : public CompositorFactory {
+ public:
+ MOCK_METHOD0(createFloatAnimationCurve, WebFloatAnimationCurve*());
+ };
+
private:
class PlatformProxy : public TestingPlatformSupport {
public:
@@ -165,7 +169,7 @@ private:
PlatformProxy m_proxyPlatform;
protected:
- virtual void SetUp()
+ void SetUp() override
{
m_mockCompositor = 0;
Platform::initialize(&m_proxyPlatform);

Powered by Google App Engine
This is Rietveld 408576698