third_party/WebKit/Source/platform/graphics/DEPS - Issue 1616653002: CC Animation: Move files from cc_blink to Source/platform/animation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/graphics/DEPS

Issue 1616653002: CC Animation: Move files from cc_blink to Source/platform/animation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add WTF_MAKE_NONCOPYABLE. Remove INSIDE_BLINK for keyframes. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.cpp ('K') | « third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.cpp ('k') | third_party/WebKit/Source/platform/graphics/GraphicsLayer.h » ('j') | third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 include_rules = [
jbroman 2016/02/01 15:44:36 We could allow these in all of platform, but I'd p We could allow these in all of platform, but I'd prefer leaving these here and adding an additional rule permitting "+cc", "-cc/blink" in platform/animation/. That way we can more easily track which parts of platform/ are using the compositor (and both animation and graphics seem reasonable). loyso (OOO) 2016/02/04 05:49:29 I have relaxed the DEPS as per discussion with esp Show quoted text On 2016/02/01 15:44:36, jbroman wrote: > We could allow these in all of platform, but I'd prefer leaving these here and > adding an additional rule permitting "+cc", "-cc/blink" in platform/animation/. > > That way we can more easily track which parts of platform/ are using the > compositor (and both animation and graphics seem reasonable). I have relaxed the DEPS as per discussion with esprehn@. But I agree, keeping it strictly scoped is better for the code in transition. Done.
2 # To whitelist base/ stuff Blink is allowed to include, we list up all

3 # directories and files instead of writing 'base/'.

4 "+base/message_loop",

5 "+cc",

6 "-cc/blink",

7 ]

OLD	NEW