Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1616643002: Rename LineLayoutPaintShim -> LineLayoutAPIShim (Closed)

Created:
4 years, 11 months ago by dgrogan
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pilgrim_google, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Line Layout API] Rename LineLayoutPaintShim -> LineLayoutAPIShim Directories other than paint/ use it now. BUG=499321 Committed: https://crrev.com/ea12f7da302edaea8cb316d11695f9d77b1b4e8c Cr-Commit-Position: refs/heads/master@{#370775}

Patch Set 1 #

Total comments: 2

Patch Set 2 : "paint objects" -> "clients" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -88 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/RenderedPosition.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 13 chunks +13 lines, -13 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/api/LineLayoutAPIShim.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LineLayoutItem.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/EllipsisBoxPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/core/paint/LineLayoutPaintShim.h View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/paint/RootInlineBoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineFlowBoxPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 12 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGRootInlineBoxPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616643002/1
4 years, 11 months ago (2016-01-21 03:42:36 UTC) #3
dgrogan
Levi, could you review this?
4 years, 11 months ago (2016-01-21 04:00:51 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-21 04:53:47 UTC) #7
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/1616643002/diff/1/third_party/WebKit/Source/core/layout/api/LineLayoutAPIShim.h File third_party/WebKit/Source/core/layout/api/LineLayoutAPIShim.h (right): https://codereview.chromium.org/1616643002/diff/1/third_party/WebKit/Source/core/layout/api/LineLayoutAPIShim.h#newcode14 third_party/WebKit/Source/core/layout/api/LineLayoutAPIShim.h:14: // TODO(pilgrim): Remove this kludge once Paint objects ...
4 years, 11 months ago (2016-01-21 05:21:05 UTC) #8
leviw_travelin_and_unemployed
Can you also add the BUG number for the Line Layout API
4 years, 11 months ago (2016-01-21 05:27:55 UTC) #9
dgrogan
On 2016/01/21 05:27:55, leviw wrote: > Can you also add the BUG number for the ...
4 years, 11 months ago (2016-01-21 18:50:28 UTC) #11
dgrogan
https://codereview.chromium.org/1616643002/diff/1/third_party/WebKit/Source/core/layout/api/LineLayoutAPIShim.h File third_party/WebKit/Source/core/layout/api/LineLayoutAPIShim.h (right): https://codereview.chromium.org/1616643002/diff/1/third_party/WebKit/Source/core/layout/api/LineLayoutAPIShim.h#newcode14 third_party/WebKit/Source/core/layout/api/LineLayoutAPIShim.h:14: // TODO(pilgrim): Remove this kludge once Paint objects have ...
4 years, 11 months ago (2016-01-21 18:50:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616643002/20001
4 years, 11 months ago (2016-01-21 18:52:01 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 20:37:27 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 20:39:13 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ea12f7da302edaea8cb316d11695f9d77b1b4e8c
Cr-Commit-Position: refs/heads/master@{#370775}

Powered by Google App Engine
This is Rietveld 408576698