Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1616613002: X87: [interpreter] First implementation of stack unwinding. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [interpreter] First implementation of stack unwinding. port 0b3066b8f5d914bb1a8c5dd0404a866d389d7798 (r33414) original commit message: This implements a first prototype of stack unwinding for interpreted frames. The unwinding machinery performs a range-based lookup in the given handler table and potentially continues dispatching at the handler offset. Note that this does not yet correctly restore the context to the correct value when the handler is being entered. BUG= Committed: https://crrev.com/02e7906e399f2970207b8c3138f67b9894d1b6eb Cr-Commit-Position: refs/heads/master@{#33425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -19 lines) Patch
M src/x87/builtins-x87.cc View 4 chunks +38 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
zhengxing.li
PTAL, Thanks!
4 years, 11 months ago (2016-01-21 03:14:16 UTC) #2
Weiliang
lgtm
4 years, 11 months ago (2016-01-21 03:27:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616613002/1
4 years, 11 months ago (2016-01-21 06:30:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 06:52:49 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 06:53:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02e7906e399f2970207b8c3138f67b9894d1b6eb
Cr-Commit-Position: refs/heads/master@{#33425}

Powered by Google App Engine
This is Rietveld 408576698