Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1616553004: Align placeholder element and inner-editor element at their baselines. (Closed)

Created:
4 years, 11 months ago by tkent
Modified:
4 years, 11 months ago
Reviewers:
kojii
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Align placeholder element and inner-editor element at their baselines. We aligned them at their top position. It was incorrect in some cases. - We reset line-height of inner-editor element in some cases, but never reset line-height of placeholder. - Even if their font settings are identical, box heights can be different if the specified font doesn't cover all of characters and another font is used. This problem happened frequently after crrev.com/369975 because we don't limit the inner-editor height since it. BUG=178032, 569869, 579381 Committed: https://crrev.com/c9a634c524cd130d78a153193c87adde0f1407e7 Cr-Commit-Position: refs/heads/master@{#370642}

Patch Set 1 : #

Messages

Total messages: 12 (7 generated)
tkent
kojii@, would you review this please?
4 years, 11 months ago (2016-01-21 06:03:08 UTC) #4
kojii
lgtm
4 years, 11 months ago (2016-01-21 06:45:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616553004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616553004/20001
4 years, 11 months ago (2016-01-21 06:47:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 11 months ago (2016-01-21 06:52:35 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 06:53:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9a634c524cd130d78a153193c87adde0f1407e7
Cr-Commit-Position: refs/heads/master@{#370642}

Powered by Google App Engine
This is Rietveld 408576698