Add function to support clearing SSL/certificate store.

Add function to support clearing SSL/certificate store.

When smartcard auth is disabled we need to wipe the store and any open
sockets. By issuing a NULL cert being added this happens.

BUG=341500
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251033

[Ryan Sleevi, 2014-02-12 22:56:22]

https://codereview.chromium.org/161653002/diff/20001/net/android/java/src/org...
File net/android/java/src/org/chromium/net/X509Util.java (right):

https://codereview.chromium.org/161653002/diff/20001/net/android/java/src/org...
net/android/java/src/org/chromium/net/X509Util.java:294: public static void
clearCertificateStore() {
This is coupling an implementation detail with the intended public interface.

notifyClientCertificatesChanged would be a more suitable name.

https://codereview.chromium.org/161653002/diff/20001/net/android/java/src/org...
net/android/java/src/org/chromium/net/X509Util.java:296:
nativeDropCertificateCache();
Ditto here and for the log message

https://codereview.chromium.org/161653002/diff/20001/net/cert/cert_database.h
File net/cert/cert_database.h (right):

https://codereview.chromium.org/161653002/diff/20001/net/cert/cert_database.h...
net/cert/cert_database.h:86: void Clear();
// On Android, the system key store may be replaced with a device-specific
KeyStore used for
// storing client certificates. When the Java side replaces the KeyStore used
for client certificates,
// notifies the observers as if a new client certificate was added.
void OnAndroidKeyStoreChanged()

https://codereview.chromium.org/161653002/diff/20001/net/cert/cert_database.h...
net/cert/cert_database.h:88: // On android, the system database is used. When
the system notifies the
s/android/Android/

[Yaron, 2014-02-12 23:24:17]

https://codereview.chromium.org/161653002/diff/20001/net/android/java/src/org...
File net/android/java/src/org/chromium/net/X509Util.java (right):

https://codereview.chromium.org/161653002/diff/20001/net/android/java/src/org...
net/android/java/src/org/chromium/net/X509Util.java:294: public static void
clearCertificateStore() {
On 2014/02/12 22:56:22, Ryan Sleevi wrote:
> This is coupling an implementation detail with the intended public interface.
> 
> notifyClientCertificatesChanged would be a more suitable name.

Done.

https://codereview.chromium.org/161653002/diff/20001/net/android/java/src/org...
net/android/java/src/org/chromium/net/X509Util.java:296:
nativeDropCertificateCache();
On 2014/02/12 22:56:22, Ryan Sleevi wrote:
> Ditto here and for the log message

Done.

https://codereview.chromium.org/161653002/diff/20001/net/cert/cert_database.h
File net/cert/cert_database.h (right):

https://codereview.chromium.org/161653002/diff/20001/net/cert/cert_database.h...
net/cert/cert_database.h:86: void Clear();
On 2014/02/12 22:56:22, Ryan Sleevi wrote:
> // On Android, the system key store may be replaced with a device-specific
> KeyStore used for
> // storing client certificates. When the Java side replaces the KeyStore used
> for client certificates,
> // notifies the observers as if a new client certificate was added.
> void OnAndroidKeyStoreChanged()

Done.

https://codereview.chromium.org/161653002/diff/20001/net/cert/cert_database.h...
net/cert/cert_database.h:88: // On android, the system database is used. When
the system notifies the
On 2014/02/12 22:56:22, Ryan Sleevi wrote:
> s/android/Android/

Done.

[Ryan Sleevi, 2014-02-13 04:01:38]

lgtm

[Yaron, 2014-02-13 06:38:58]

The CQ bit was checked by yfriedman@chromium.org

[commit-bot: I haz the power, 2014-02-13 06:39:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/161653002/100001

[commit-bot: I haz the power, 2014-02-13 15:51:35]

Change committed as 251033