Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 16165003: Re-disable flaky insertion handle tests (Closed)

Created:
7 years, 6 months ago by Cait (Slow)
Modified:
7 years, 6 months ago
Reviewers:
cjhopman, dharcourt
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Re-disable flaky android InsertionHandle tests TBR=dharcourt@chromium.org BUG=169648 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202614

Patch Set 1 #

Total comments: 2

Patch Set 2 : Only disable teh flaky ones #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java View 1 5 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Cait (Slow)
7 years, 6 months ago (2013-05-28 18:02:13 UTC) #1
dharcourt
https://chromiumcodereview.appspot.com/16165003/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java (right): https://chromiumcodereview.appspot.com/16165003/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java#newcode131 content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java:131: @DisabledTest I only see the two testDragInsertionHandleInputText* tests failing ...
7 years, 6 months ago (2013-05-28 18:13:07 UTC) #2
Cait (Slow)
https://chromiumcodereview.appspot.com/16165003/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java (right): https://chromiumcodereview.appspot.com/16165003/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java#newcode131 content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java:131: @DisabledTest On 2013/05/28 18:13:07, dharcourt wrote: > I only ...
7 years, 6 months ago (2013-05-28 18:19:56 UTC) #3
dharcourt
lgtm
7 years, 6 months ago (2013-05-28 18:22:01 UTC) #4
cjhopman
On 2013/05/28 18:19:56, caitkp wrote: > https://chromiumcodereview.appspot.com/16165003/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java > File > content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java > (right): > > ...
7 years, 6 months ago (2013-05-28 18:23:13 UTC) #5
Cait (Slow)
7 years, 6 months ago (2013-05-28 18:53:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r202614 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698