third_party/WebKit/Source/core/css/CSSSelectorList.cpp - Issue 1616423003: Fix selector namespace prefix resolution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSSelectorList.cpp

Issue 1616423003: Fix selector namespace prefix resolution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review issues Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSSelectorList.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSSelectorList.cpp b/third_party/WebKit/Source/core/css/CSSSelectorList.cpp

index 83626a2d18c6d5bb2ffac4851aa402ce63eec60d..361d99bcd219bf353b2c9d8e144440cfaae9278b 100644

--- a/third_party/WebKit/Source/core/css/CSSSelectorList.cpp

+++ b/third_party/WebKit/Source/core/css/CSSSelectorList.cpp

@@ -151,16 +151,6 @@ static bool forEachSelector(const Functor& functor, const CSSSelectorList* selec

return false;

}

-bool CSSSelectorList::selectorsNeedNamespaceResolution()

- return forEachSelector([](const CSSSelector& selector) -> bool {

- if (selector.match() != CSSSelector::Tag && !selector.isAttributeSelector())

- return false;

- const AtomicString& prefix = selector.isAttributeSelector() ? selector.attribute().prefix() : selector.tagQName().prefix();

- return prefix != nullAtom && prefix != emptyAtom && prefix != starAtom;

- }, this);

bool CSSSelectorList::selectorHasContentPseudo(size_t index) const

{

return forEachTagSelector([](const CSSSelector& selector) -> bool {