Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 1616393002: Bug fix: A bug in android-sync tool (Closed)

Created:
4 years, 11 months ago by Bangfu
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Bug fix: A bug in android-sync tool BUG= A bug in android-sync.sh, which caused the android_arm.release.check unittests crash on device. It is fixed by adding: sync_file "$OUTDIR/$ARCH_MODE/natives_blob.bin" sync_file "$OUTDIR/$ARCH_MODE/snapshot_blob.bin" Committed: https://crrev.com/8cb0c0b9272d8bc1d9fb390d064f03d292f665e5 Cr-Commit-Position: refs/heads/master@{#33578}

Patch Set 1 #

Patch Set 2 : Bug fix: A bug in android-sync tool #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M AUTHORS View 1 2 chunks +2 lines, -1 line 0 comments Download
M tools/android-sync.sh View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Bangfu
Hi Jochen & Yang Please review the fix for v8 unittests on android device. Thanks ...
4 years, 11 months ago (2016-01-22 10:05:51 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2016-01-22 14:35:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616393002/1
4 years, 11 months ago (2016-01-27 17:37:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10225)
4 years, 11 months ago (2016-01-27 17:41:56 UTC) #7
Bangfu
On 2016/01/27 17:41:56, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 10 months ago (2016-01-28 09:46:57 UTC) #8
jochen (gone - plz use gerrit)
yep, the CLA is fine. Just add your email address in this CL to AUTHORS
4 years, 10 months ago (2016-01-28 09:50:02 UTC) #9
Bangfu
On 2016/01/28 09:50:02, jochen wrote: > yep, the CLA is fine. Just add your email ...
4 years, 10 months ago (2016-01-28 10:10:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616393002/20001
4 years, 10 months ago (2016-01-28 10:35:27 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 11:05:49 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 11:06:34 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8cb0c0b9272d8bc1d9fb390d064f03d292f665e5
Cr-Commit-Position: refs/heads/master@{#33578}

Powered by Google App Engine
This is Rietveld 408576698