Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1616263005: Add CustomEvent (Closed)

Created:
4 years, 11 months ago by vsm
Modified:
4 years, 10 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org, devoncarew
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add CustomEvent This just mechanically adds CustomEvent. Fixes #423 R=jacobr@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/32a410b9ee3792b1db5354fb74e182d7b6a64575

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rgen #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1044 lines, -222 lines) Patch
M lib/runtime/dart/html.js View 1 7 chunks +217 lines, -146 lines 0 comments Download
A lib/runtime/messages_widget.js.map View 1 1 chunk +8 lines, -0 lines 0 comments Download
M test/codegen/expect/collection/src/unmodifiable_wrappers.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/src/wrappers.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
M tool/input_sdk/lib/html/ddc/html_ddc.dart View 1 4 chunks +85 lines, -5 lines 0 comments Download
A tool/input_sdk/lib/indexed_db/ddc/indexed_db_ddc.dart View 1 1 chunk +218 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/svg/ddc/svg_ddc.dart View 1 1 chunk +47 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/web_audio/ddc/web_audio_ddc.dart View 1 1 chunk +31 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/web_gl/ddc/web_gl_ddc.dart View 1 1 chunk +332 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/web_sql/ddc/web_sql_ddc.dart View 1 1 chunk +36 lines, -0 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 2 chunks +64 lines, -65 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
vsm
4 years, 11 months ago (2016-01-22 20:26:23 UTC) #3
Jacob
https://codereview.chromium.org/1616263005/diff/1/tool/input_sdk/lib/html/ddc/html_ddc.dart File tool/input_sdk/lib/html/ddc/html_ddc.dart (right): https://codereview.chromium.org/1616263005/diff/1/tool/input_sdk/lib/html/ddc/html_ddc.dart#newcode3973 tool/input_sdk/lib/html/ddc/html_ddc.dart:3973: try { you sure this works? i'm having trouble ...
4 years, 10 months ago (2016-01-28 17:57:43 UTC) #4
Jacob
lgtm
4 years, 10 months ago (2016-01-28 18:07:41 UTC) #5
vsm
4 years, 10 months ago (2016-01-29 01:04:22 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
32a410b9ee3792b1db5354fb74e182d7b6a64575 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698