Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1616233002: Fix RegExp.prototype.compile.length to be 2 (Closed)

Created:
4 years, 11 months ago by Dan Ehrenberg
Modified:
4 years, 11 months ago
Reviewers:
yangguo, adamk, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix RegExp.prototype.compile.length to be 2 SpiderMonkey switched to 2, test262 tests for 2, and 2 is a reasonable, natural value. R=yangguo Committed: https://crrev.com/efcd023e4a58ef9a40169a8631ebe8552d4c9067 Cr-Commit-Position: refs/heads/master@{#33504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/js/regexp.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/mjsunit/regexp-compile.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616233002/1
4 years, 11 months ago (2016-01-22 01:01:04 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-22 02:06:52 UTC) #4
Dan Ehrenberg
4 years, 11 months ago (2016-01-22 16:14:07 UTC) #5
Dan Ehrenberg
PTAL
4 years, 11 months ago (2016-01-26 06:03:49 UTC) #7
Yang
On 2016/01/26 06:03:49, Dan Ehrenberg wrote: > PTAL lgtm
4 years, 11 months ago (2016-01-26 06:18:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616233002/1
4 years, 11 months ago (2016-01-26 06:21:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 06:42:31 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 06:43:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efcd023e4a58ef9a40169a8631ebe8552d4c9067
Cr-Commit-Position: refs/heads/master@{#33504}

Powered by Google App Engine
This is Rietveld 408576698