third_party/WebKit/Source/web/WebPagePopupImpl.cpp - Issue 1616183002: Don't composite layers with an invisible frameview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 1616183002: Don't composite layers with an invisible frameview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test expectation. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

index 541a27877473db84456caaa249127ae2ad98fe4a..f457c23b7988b342cada4aa4be3216dc301b4cd1 100644

--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

@@ -259,6 +259,8 @@ bool WebPagePopupImpl::initializePage()

frame->setPagePopupOwner(m_popupClient->ownerElement());

frame->setView(FrameView::create(frame.get()));

frame->init();

+ frame->view()->setParentVisible(true);

+ frame->view()->setSelfVisible(true);

frame->view()->setTransparent(false);

if (AXObjectCache* cache = m_popupClient->ownerElement().document().existingAXObjectCache())

cache->childrenChanged(&m_popupClient->ownerElement());

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp ('k') | no next file » | no next file with comments »