third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp - Issue 1616183002: Don't composite layers with an invisible frameview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

Issue 1616183002: Don't composite layers with an invisible frameview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test expectation. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTestHelper.h ('k') | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp b/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

index 0d83855a8eadaad011b0757470bd4c8ce41bebcc..8d6a3909ec8199529c85769e452bdc256d3a5339 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

@@ -67,6 +67,8 @@ Document& RenderingTest::setupChildIframe(const AtomicString& iframeElementId, c

m_subframe = LocalFrame::create(m_frameLoaderClient.get(), document().frame()->host(), &iframe);

m_subframe->setView(FrameView::create(m_subframe.get(), IntSize(500, 500)));

m_subframe->init();

+ m_subframe->view()->setParentVisible(true);

+ m_subframe->view()->setSelfVisible(true);

static_cast<SingleChildFrameLoaderClient*>(document().frame()->client())->setChild(m_subframe.get());

document().frame()->host()->incrementSubframeCount();

Document& frameDocument = *iframe.contentDocument();