third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 1616183002: Don't composite layers with an invisible frameview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1616183002: Don't composite layers with an invisible frameview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test expectation. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/resources/square-blue-100x100.png ('k') | third_party/WebKit/Source/core/frame/FrameViewTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index a6304a708559976dd77b0674c4d684c51db6b62f..8fd998469f2911b20aeab32156be4d00ed65c89d 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -3801,6 +3801,10 @@ void FrameView::setParentVisible(bool visible)

if (isParentVisible() == visible)

return;

+ // As parent visibility changes, we may need to recomposite this frame view and potentially child frame views.

+ if (PaintLayerCompositor* compositor = layoutView() ? layoutView()->compositor() : nullptr)

+ compositor->setNeedsCompositingUpdate(CompositingUpdateRebuildTree);

Widget::setParentVisible(visible);

if (!isSelfVisible())