Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: third_party/WebKit/LayoutTests/compositing/composited-iframe-hidden.html

Issue 1616183002: Don't composite layers with an invisible frameview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add test expectation. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/compositing/composited-iframe-hidden.html
diff --git a/third_party/WebKit/LayoutTests/compositing/composited-iframe-hidden.html b/third_party/WebKit/LayoutTests/compositing/composited-iframe-hidden.html
new file mode 100644
index 0000000000000000000000000000000000000000..2259f1acabb31f672672315fc255677434f4d089
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/compositing/composited-iframe-hidden.html
@@ -0,0 +1,36 @@
+<!DOCTYPE html>
+<script src="../resources/run-after-layout-and-paint.js"></script>
+<div id="frameContainer">
+ <iframe src="./resources/composited-iframe-hidden-subframe.html"></iframe>
+</div>
+<p>This test passes if there is no assert failure in debug builds and there is no visible
+content in the iframe above after the page fully settles.
+<script>
+function hideFrameContainer() {
+ frameContainer.style.visibility = 'hidden';
+}
+
+function showFrameContainer() {
+ frameContainer.style.visibility = 'visible';
+}
+
+// We were seeing assert failure when we hid and then re-showed the iframe due
+// to a stale graphics layer with an old invalidation posted by the animated
+// element. To prevent regression we hide and re-show the iframe, and hide again
+// to ensure the content is actually hidden.
+if (window.testRunner)
+ testRunner.waitUntilDone();
+runAfterLayoutAndPaint(function() {
+ hideFrameContainer();
+ runAfterLayoutAndPaint(function() {
+ showFrameContainer();
+ runAfterLayoutAndPaint(function() {
+ hideFrameContainer();
+ if (window.testRunner)
+ runAfterLayoutAndPaint(function() {
+ testRunner.notifyDone();
+ });
+ });
+ });
+});
+</script>

Powered by Google App Engine
This is Rietveld 408576698