Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1616183002: Don't composite layers with an invisible frameview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove verbose logging. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index a6304a708559976dd77b0674c4d684c51db6b62f..a3f45decc8ba109fd3b56ebe5b69b47aec2cba06 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -3801,6 +3801,10 @@ void FrameView::setParentVisible(bool visible)
if (isParentVisible() == visible)
return;
+ // As parent visibility changes, we may need to recomposite this frame view and potentially child frame views.
+ if (PaintLayerCompositor* compositor = layoutView() ? layoutView()->compositor() : nullptr)
+ compositor->setNeedsCompositingUpdate(CompositingUpdateRebuildTree);
+
Widget::setParentVisible(visible);
if (!isSelfVisible())
@@ -3816,8 +3820,9 @@ void FrameView::show()
setSelfVisible(true);
updateScrollableAreaSet();
if (isParentVisible()) {
- for (const auto& child : m_children)
+ for (const auto& child : m_children) {
chrishtr 2016/01/28 00:32:31 Remove curlies.
wkorman 2016/01/28 00:55:21 Done.
child->setParentVisible(true);
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698