third_party/WebKit/LayoutTests/compositing/composited-iframe-hidden.html - Issue 1616183002: Don't composite layers with an invisible frameview.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/compositing/composited-iframe-hidden.html

Issue 1616183002: Don't composite layers with an invisible frameview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Run test script when test runner is not present. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/compositing/composited-iframe-hidden-expected.html » ('j') | third_party/WebKit/LayoutTests/compositing/resources/composited-iframe-hidden-2.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/run-after-layout-and-paint.js"></script>

	3 <div id="frameContainer">

	4 <iframe src="./resources/composited-iframe-hidden-2.html"></iframe>

	5 </div>

	6 <script>

	7 function showDialog() {

	8 frameContainer.style.visibility = 'hidden';

	9 popup.style.display = '';

	10 }

	11

	12 function hideDialog() {

	13 frameContainer.style.visibility = 'visible';

	14 popup.style.display = 'none';

	15 }

	16 </script>

	17 <div id="settings" onclick="showDialog();">Settings</div>

	18 <div id="popup" style="display: none;" onclick="hideDialog();">

	19 Cancel

	20 </div>

	21 <p>To test manually, click on 'Settings' and then click on 'Cancel'. The iframe above should disappear (and all contents

	22 vanish) and then reappear and there should be no assert failure in debug builds.

	23 <script>

	24 // We were seeing assert failure when we hid and then re-showed the iframe due

	25 // to a stale graphics layer with an old invalidation posted by the animated

	26 // element. To prevent regression we hide and re-show the iframe, and hide again

	27 // to ensure the content is actually hidden.

	28 if (window.testRunner)

	29 testRunner.waitUntilDone();

	30 runAfterLayoutAndPaint(function() {

	31 settings.click();

	32 runAfterLayoutAndPaint(function() {

	33 popup.click();
	chrishtr 2016/01/21 22:49:18 Instead of going through onclick, just set its sty Instead of going through onclick, just set its style directly by calling hideDialog() or inlining the style here. wkorman 2016/01/22 00:19:56 Done. Show quoted text On 2016/01/21 at 22:49:18, chrishtr wrote: > Instead of going through onclick, just set its style directly by calling hideDialog() or inlining > the style here. Done.
	34 runAfterLayoutAndPaint(function() {

	35 settings.click();

	36 if (window.testRunner)

	37 runAfterLayoutAndPaint(function() {

	38 testRunner.notifyDone();

	39 });

	40 });

	41 });

	42 });

	43 </script>

OLD	NEW