Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameViewTest.cpp

Issue 1616183002: Don't composite layers with an invisible frameview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add test expectation. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/FrameView.h" 5 #include "core/frame/FrameView.h"
6 6
7 #include "bindings/core/v8/ExceptionStatePlaceholder.h" 7 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
8 #include "core/frame/Settings.h" 8 #include "core/frame/Settings.h"
9 #include "core/html/HTMLElement.h" 9 #include "core/html/HTMLElement.h"
10 #include "core/layout/LayoutObject.h" 10 #include "core/layout/LayoutObject.h"
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 { 83 {
84 // We shouldn't attach a root graphics layer. In this mode, that's not 84 // We shouldn't attach a root graphics layer. In this mode, that's not
85 // our responsibility. 85 // our responsibility.
86 EXPECT_CALL(chromeClient(), attachRootGraphicsLayer(_, _)).Times(0); 86 EXPECT_CALL(chromeClient(), attachRootGraphicsLayer(_, _)).Times(0);
87 } 87 }
88 88
89 void SetUp() override 89 void SetUp() override
90 { 90 {
91 RuntimeEnabledFeatures::setSlimmingPaintV2Enabled(true); 91 RuntimeEnabledFeatures::setSlimmingPaintV2Enabled(true);
92 FrameViewTestBase::SetUp(); 92 FrameViewTestBase::SetUp();
93 document().view()->setParentVisible(true);
94 document().view()->setSelfVisible(true);
93 } 95 }
94 96
95 void TearDown() override 97 void TearDown() override
96 { 98 {
97 m_featuresBackup.restore(); 99 m_featuresBackup.restore();
98 } 100 }
99 101
100 private: 102 private:
101 RuntimeEnabledFeatures::Backup m_featuresBackup; 103 RuntimeEnabledFeatures::Backup m_featuresBackup;
102 }; 104 };
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 chromeClient().m_hasScheduledAnimation = false; 139 chromeClient().m_hasScheduledAnimation = false;
138 document().getElementById("a")->layoutObject()->setShouldDoFullPaintInvalida tion(); 140 document().getElementById("a")->layoutObject()->setShouldDoFullPaintInvalida tion();
139 EXPECT_TRUE(chromeClient().m_hasScheduledAnimation); 141 EXPECT_TRUE(chromeClient().m_hasScheduledAnimation);
140 chromeClient().m_hasScheduledAnimation = false; 142 chromeClient().m_hasScheduledAnimation = false;
141 document().view()->updateAllLifecyclePhases(); 143 document().view()->updateAllLifecyclePhases();
142 EXPECT_FALSE(chromeClient().m_hasScheduledAnimation); 144 EXPECT_FALSE(chromeClient().m_hasScheduledAnimation);
143 } 145 }
144 146
145 } // namespace 147 } // namespace
146 } // namespace blink 148 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTestHelper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698