third_party/WebKit/LayoutTests/compositing/composited-iframe-hidden.html - Issue 1616183002: Don't composite layers with an invisible frameview.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/compositing/composited-iframe-hidden.html

Issue 1616183002: Don't composite layers with an invisible frameview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove verbose logging. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/compositing/composited-iframe-hidden-expected.html » ('j') | third_party/WebKit/LayoutTests/compositing/composited-iframe-hidden-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/run-after-layout-and-paint.js"></script>

	3 <div id="frameContainer">

	4 <iframe src="./resources/composited-iframe-hidden-2.html"></iframe>

	5 </div>

	6 <p>This test passes if there is no assert failure in debug builds and there is n o visible

	7 content in the iframe above after the page fully settles.

	8 <script>

	9 function hideFrameContainer() {

	10 frameContainer.style.visibility = 'hidden';

	11 }

	12

	13 function showFrameContainer() {

	14 frameContainer.style.visibility = 'visible';

	15 }

	16

	17 // We were seeing assert failure when we hid and then re-showed the iframe due

	18 // to a stale graphics layer with an old invalidation posted by the animated

	19 // element. To prevent regression we hide and re-show the iframe, and hide again

	20 // to ensure the content is actually hidden.

	21 if (window.testRunner)

	22 testRunner.waitUntilDone();

	23 runAfterLayoutAndPaint(function() {

	24 hideFrameContainer();

	25 runAfterLayoutAndPaint(function() {

	26 showFrameContainer();

	27 runAfterLayoutAndPaint(function() {

	28 hideFrameContainer();

	29 if (window.testRunner)

	30 runAfterLayoutAndPaint(function() {

	31 testRunner.notifyDone();

	32 });

	33 });

	34 });

	35 });

	36 </script>

OLD	NEW