third_party/WebKit/LayoutTests/compositing/composited-iframe-hidden-expected.html - Issue 1616183002: Don't composite layers with an invisible frameview.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/compositing/composited-iframe-hidden-expected.html

Issue 1616183002: Don't composite layers with an invisible frameview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove verbose logging. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/composited-iframe-hidden.html ('k') | third_party/WebKit/LayoutTests/compositing/iframes/invisible-nested-iframe-show.html » ('j') | third_party/WebKit/LayoutTests/compositing/resources/composited-iframe-hidden-2.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <div style="visibility: hidden;"><iframe></iframe></div>
	chrishtr 2016/01/28 00:32:31 Just <div></div should work? Just <div></div should work? wkorman 2016/01/28 00:55:21 Since the hidden iframe still occupies space, we n Show quoted text On 2016/01/28 at 00:32:31, chrishtr wrote: > Just <div></div should work? Since the hidden iframe still occupies space, we need to account for that space in this expectation somehow. This seemed like the most maintainable approach since it emulates the source document re: using an actual iframe element. We could alternately see what the size of the default-styled iframe is (150px high + 4px for border) and apply that to the padding/margin-top of the <p> below but then that's fragile to iframe changes in future. Am happy to do that instead if you think preferred.
	3 <p>This test passes if there is no assert failure in debug builds and there is n o visible

	4 content in the iframe above after the page fully settles.

OLD	NEW