pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart - Issue 1616143003: Lower map literals to constructor or function calls in builder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

Issue 1616143003: Lower map literals to constructor or function calls in builder (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('k') | pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

diff --git a/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart b/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

index 3b3a74ae874fa04db860bb1af99cac927d353327..1ada85b35d751f2d603a924a6735d1dbc2a342f6 100644

--- a/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

+++ b/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

@@ -292,14 +292,6 @@ class PullIntoInitializers extends RecursiveTransformer

return node;

}

- Expression visitLiteralMap(LiteralMap node) {

- super.visitLiteralMap(node);

- if (node.type != null) {

- ++impureCounter; // Type casts can throw.

- }

- return node;

- }

Expression visitTypeOperator(TypeOperator node) {

super.visitTypeOperator(node);

if (!node.isTypeTest) {