Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1755)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1616143003: Lower map literals to constructor or function calls in builder (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index 07c3ff1043cd2658e7e46eb0f808ef570c6ddbcc..903fa7c29ba416f13a32377215431c1d8e7fedc1 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -370,26 +370,6 @@ class CodeGenerator extends tree_ir.StatementVisitor
}
@override
- js.Expression visitLiteralMap(tree_ir.LiteralMap node) {
- ConstructorElement constructor;
- if (node.entries.isEmpty) {
- constructor = glue.mapLiteralConstructorEmpty;
- } else {
- constructor = glue.mapLiteralConstructor;
- }
- List<js.Expression> entries =
- new List<js.Expression>(2 * node.entries.length);
- for (int i = 0; i < node.entries.length; i++) {
- entries[2 * i] = visitExpression(node.entries[i].key);
- entries[2 * i + 1] = visitExpression(node.entries[i].value);
- }
- List<js.Expression> args = entries.isEmpty
- ? <js.Expression>[]
- : <js.Expression>[new js.ArrayInitializer(entries)];
- return buildStaticInvoke(constructor, args);
- }
-
- @override
js.Expression visitLogicalOperator(tree_ir.LogicalOperator node) {
return new js.Binary(
node.operator,

Powered by Google App Engine
This is Rietveld 408576698