Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1616143003: Lower map literals to constructor or function calls in builder (Closed)

Created:
4 years, 11 months ago by sra1
Modified:
4 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Lower map literals to constructor or function calls in builder Remove LiteralMap from cps_ir and tree_ir. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/33ac12a5a4ff4788e5acaf9c44d59c62bea647a5

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -180 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 1 chunk +41 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 4 chunks +0 lines, -46 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 1 2 chunks +0 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 1 chunk +0 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart View 1 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 1 chunk +0 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 5 chunks +0 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart View 1 1 chunk +0 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/basic_1.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/literals_1.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
sra1
4 years, 11 months ago (2016-01-22 02:52:12 UTC) #4
asgerf
lgtm https://codereview.chromium.org/1616143003/diff/40001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1616143003/diff/40001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode1341 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:1341: if (type.isRaw) { I believe we should use ...
4 years, 11 months ago (2016-01-22 03:14:20 UTC) #5
sra1
https://codereview.chromium.org/1616143003/diff/40001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1616143003/diff/40001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode1341 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:1341: if (type.isRaw) { On 2016/01/22 03:14:20, asgerf wrote: > ...
4 years, 11 months ago (2016-01-22 03:32:04 UTC) #6
sra1
4 years, 11 months ago (2016-01-22 03:32:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as
33ac12a5a4ff4788e5acaf9c44d59c62bea647a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698