Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: components/gcm_driver/gcm_driver.cc

Issue 1616113003: List message decryption failures on chrome://gcm-internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase after CL 1619053003 Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/gcm_driver.h ('k') | components/gcm_driver/gcm_driver_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_driver.cc
diff --git a/components/gcm_driver/gcm_driver.cc b/components/gcm_driver/gcm_driver.cc
index 3a0246a76bf2b9d9e63f3850e531840013bb8f53..db98afa9bb6029d7807797037e1c5cbc64576a86 100644
--- a/components/gcm_driver/gcm_driver.cc
+++ b/components/gcm_driver/gcm_driver.cc
@@ -19,11 +19,6 @@ namespace {
const size_t kMaxSenders = 100;
-// TODO(peter): Implement an event for GCMAppHandlers that should be called
-// when decryption of an incoming message has failed.
-void DecryptionFailedCallback(
- GCMEncryptionProvider::DecryptionFailure reason) {}
-
} // namespace
InstanceIDHandler::InstanceIDHandler() {
@@ -280,7 +275,8 @@ void GCMDriver::DispatchMessage(const std::string& app_id,
app_id, message,
base::Bind(&GCMDriver::DispatchMessage,
weak_ptr_factory_.GetWeakPtr(), app_id),
- base::Bind(&DecryptionFailedCallback));
+ base::Bind(&GCMDriver::RecordDecryptionFailure,
+ weak_ptr_factory_.GetWeakPtr(), app_id));
}
void GCMDriver::RegisterAfterUnregister(
« no previous file with comments | « components/gcm_driver/gcm_driver.h ('k') | components/gcm_driver/gcm_driver_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698