unittest/AssemblerX8664/GPRArith.cpp - Issue 1616103002: Subzero. X8664. Enables RIP-based addressing mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: unittest/AssemblerX8664/GPRArith.cpp

Issue 1616103002: Subzero. X8664. Enables RIP-based addressing mode. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addresses comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: unittest/AssemblerX8664/GPRArith.cpp

diff --git a/unittest/AssemblerX8664/GPRArith.cpp b/unittest/AssemblerX8664/GPRArith.cpp

index 2ec85cc5aa5208542f4e8ec0c76ca55ffb8f4f01..aad2e77cc599c9f2526f5b7edad9b5c299fbbeb8 100644

--- a/unittest/AssemblerX8664/GPRArith.cpp

+++ b/unittest/AssemblerX8664/GPRArith.cpp

@@ -328,7 +328,7 @@ TEST_F(AssemblerX8664LowLevelTest, LeaAbsolute) {

do { \

static constexpr char TestString[] = "(" #Dst ", " #Value ")"; \

__ lea(IceType_i32, GPRRegister::Encoded_Reg_##Dst, \

- Address(Value, AssemblerFixup::NoFixup)); \

+ Address::Absolute(Value)); \

static constexpr uint32_t ByteCount = 8; \

ASSERT_EQ(ByteCount, codeBytesSize()) << TestString; \

static constexpr uint8_t Opcode = 0x8D; \

« no previous file with comments | « src/IceTargetLoweringX8664Traits.h ('k') | unittest/AssemblerX8664/Locked.cpp » ('j') | no next file with comments »