Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: Makefile.standalone

Issue 1616103002: Subzero. X8664. Enables RIP-based addressing mode. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: make presubmit happy. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceAssemblerX86Base.h » ('j') | src/IceAssemblerX86BaseImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Makefile.standalone
diff --git a/Makefile.standalone b/Makefile.standalone
index 98ba05ed2321a39ad7ec943a9ecac07fedaacfed..a265a31aea3a13811fd2fb07e071cbdee652507a 100644
--- a/Makefile.standalone
+++ b/Makefile.standalone
@@ -137,10 +137,15 @@ endif
ifdef FORCEASM
FORCEASM_FLAG = --filetype=asm
- # With --filetype=asm and --sandbox, the llvm-mc assembler emits the lock and
- # 16-bit prefixes in the "wrong" order, causing the validator to reject the
- # resulting nexe. So we just disable those tests for now.
- FORCEASM_XTEST_EXCLUDES = -e x8632,sandbox,test_sync_atomic
+ # With --filetype=asm and --sandbox:
+ # (1) the llvm-mc assembler emits the lock and 16-bit prefixes in the "wrong"
+ # order, causing the validator to reject the resulting nexe.
+ # (2) the llvm-mc assembler fails to assemble rip/eip-based addresses.
+ # So we just disable those tests for now.
+ FORCEASM_XTEST_EXCLUDES = \
+ -e x8632,sandbox,test_sync_atomic \
+ -e x8664,sandbox,test_calling_conv \
+ -e x8664,sandbox,test_global
FORCEASM_LIT_PARAM = --param=FORCEASM
# x86 sandboxing lit tests are disabled because llvm-mc uses different
# relocations for pushing return addresses onto the stack.
« no previous file with comments | « no previous file | src/IceAssemblerX86Base.h » ('j') | src/IceAssemblerX86BaseImpl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698