de-proc sk_float_rsqrt

de-proc sk_float_rsqrt

This is the first of many little baby steps to have us stop runtime-detecting NEON.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1616013003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/efcc125acd2d71eb077caf6db65fdd6b9eb1dc0d

Committed: https://skia.googlesource.com/skia/+/a766ca87bfb1129a8cf4f8a428121caf60726de4

[mtklein_C, 2016-01-21 20:54:56]

Description was changed from

==========
de-proc sk_float_rsqrt

This is the first of many little baby steps to have us stop runtime-detecting
NEON.

BUG=skia:
==========

to

==========
de-proc sk_float_rsqrt

This is the first of many little baby steps to have us stop runtime-detecting
NEON.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-01-21 20:56:00]

mtklein@chromium.org changed reviewers:
+ reed@google.com

[mtklein_C, 2016-01-21 20:56:00]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-01-21 20:56:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1616013003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1616013003/1

[commit-bot: I haz the power, 2016-01-21 20:56:12]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-01-22 02:56 UTC

[commit-bot: I haz the power, 2016-01-21 20:57:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 20:57:11]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.9-Clang-...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[mtklein, 2016-01-21 21:12:20]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 21:12:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1616013003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1616013003/20001

[reed1, 2016-01-21 22:10:39]

unittest for the logic of the portable rsqrt approximator? perhaps that code
itself we have as a (private) helper function, which we conditionally call based
on your ifdefs. That way the test code could invoke it directly.

[commit-bot: I haz the power, 2016-01-21 23:10:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 23:10:15]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-01-22 13:53:02]

https://codereview.chromium.org/1616013003/diff/20001/src/opts/SkFloatingPoin...
File src/opts/SkFloatingPoint_opts.h (left):

https://codereview.chromium.org/1616013003/diff/20001/src/opts/SkFloatingPoin...
src/opts/SkFloatingPoint_opts.h:20: static float rsqrt(float x) {
The portable rsqrt() logic has not changed.

It's still covered by the unit test in MathTest, but you're right, no Test bot
of ours will run it now (some do continue to compile it).

[reed1, 2016-01-22 16:22:56]

Ah, meaning if we run MathTest on a machine with neither NEON nor SSE, it will
get tested? Do we have such a bot? If so, lgtm

[mtklein, 2016-01-22 16:31:10]

On 2016/01/22 16:22:56, reed1 wrote:
> Ah, meaning if we run MathTest on a machine with neither NEON nor SSE, it will
> get tested? Do we have such a bot? If so, lgtm

Yes it would get tested, but as of yesterday we don't have such a bot.

I've split out the portable code and am now testing it separately.

[mtklein, 2016-01-22 16:31:56]

The CQ bit was checked by mtklein@google.com

[mtklein, 2016-01-22 16:31:56]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1616013003/#ps40001
(title: "test both")

[commit-bot: I haz the power, 2016-01-22 16:32:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1616013003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1616013003/40001

[commit-bot: I haz the power, 2016-01-22 16:49:28]

Description was changed from

==========
de-proc sk_float_rsqrt

This is the first of many little baby steps to have us stop runtime-detecting
NEON.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
de-proc sk_float_rsqrt

This is the first of many little baby steps to have us stop runtime-detecting
NEON.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/efcc125acd2d71eb077caf6db65fdd6b9eb1dc0d
==========

[commit-bot: I haz the power, 2016-01-22 16:49:29]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/efcc125acd2d71eb077caf6db65fdd6b9eb1dc0d

[mtklein, 2016-01-22 19:51:29]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1629503002/ by mtklein@google.com.

The reason for reverting is: This is somehow blocking the Google3 roll in ways
neither Ben nor I understand.  Precautionary revert... will try again Monday..

[mtklein, 2016-01-22 19:58:42]

On 2016/01/22 19:51:29, mtklein wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/1629503002/ by mailto:mtklein@google.com.
> 
> The reason for reverting is: This is somehow blocking the Google3 roll in ways
> neither Ben nor I understand.  Precautionary revert... will try again Monday..

Reminder to self: reproduce with --config=android_arm

[mtklein, 2016-01-26 15:29:26]

Description was changed from

==========
de-proc sk_float_rsqrt

This is the first of many little baby steps to have us stop runtime-detecting
NEON.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/efcc125acd2d71eb077caf6db65fdd6b9eb1dc0d
==========

to

==========
de-proc sk_float_rsqrt

This is the first of many little baby steps to have us stop runtime-detecting
NEON.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/efcc125acd2d71eb077caf6db65fdd6b9eb1dc0d
==========

[mtklein, 2016-01-26 15:29:32]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-01-26 15:29:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1616013003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1616013003/40001

[commit-bot: I haz the power, 2016-01-26 15:40:35]

Description was changed from

==========
de-proc sk_float_rsqrt

This is the first of many little baby steps to have us stop runtime-detecting
NEON.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/efcc125acd2d71eb077caf6db65fdd6b9eb1dc0d
==========

to

==========
de-proc sk_float_rsqrt

This is the first of many little baby steps to have us stop runtime-detecting
NEON.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/efcc125acd2d71eb077caf6db65fdd6b9eb1dc0d

Committed:
https://skia.googlesource.com/skia/+/a766ca87bfb1129a8cf4f8a428121caf60726de4
==========

[commit-bot: I haz the power, 2016-01-26 15:40:35]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a766ca87bfb1129a8cf4f8a428121caf60726de4