Issue 1616004: Fix Regression for Accessible Names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1616004: Fix Regression for Accessible Names (Closed)

Created:
10 years, 8 months ago by Mohamed Mansour

Modified:
9 years, 6 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, Jonas Klink (Google), Chris Guillory

Visibility:
Public.

Description

Fix Regression for Accessible Names appearing as NAMELESS. The refactoring in r43558 caused SetAccessibleName and GetAccessibleName to be none virtual causing couple of components not having accessible names since they depend on overriding it. The following change sets the accessible name directly since view now stores it. BUG=40343 TEST=With AccExplorer32 check if accessible names have been resolved. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43584

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -42 lines)			Patch
M	chrome/browser/views/browser_actions_container.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/views/browser_actions_container.cc	View	4 chunks	+4 lines, -12 lines	0 comments	Download
M	chrome/browser/views/tabs/tab.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/views/tabs/tab.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_renderer.cc	View	1 chunk	+3 lines, -0 lines	1 comment	Download
M	views/controls/image_view.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	views/controls/image_view.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	views/controls/label.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	views/controls/label.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	views/controls/link.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	views/controls/link.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

10 years, 8 months ago (2010-04-04 01:20:12 UTC) #2

LGTM.  Clearly, I only remembered to grep for the Set call, not the Get call. 
Sorry.  Thanks for fixing this.

http://codereview.chromium.org/1616004/diff/1/6
File chrome/browser/views/tabs/tab_renderer.cc (right):

http://codereview.chromium.org/1616004/diff/1/6#newcode316
chrome/browser/views/tabs/tab_renderer.cc:316: SetAccessibleName(data_.title);
I don't know the tab code well enough to know if this is the only place the
title is updated.  If it is, then OK.

Expand Messages | Collapse Messages