Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: runtime/vm/assembler_mips.cc

Issue 16160013: Changes to run "Hello, world!" on MIPS hardware. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/third_party/double-conversion/src/utils.h ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_mips.cc
===================================================================
--- runtime/vm/assembler_mips.cc (revision 23469)
+++ runtime/vm/assembler_mips.cc (working copy)
@@ -12,7 +12,9 @@
namespace dart {
+#if defined(USING_SIMULATOR)
DECLARE_FLAG(bool, trace_sim);
+#endif
DEFINE_FLAG(bool, print_stop_message, false, "Print stop message.");
@@ -460,7 +462,9 @@
void Assembler::ReserveAlignedFrameSpace(intptr_t frame_space) {
// Reserve space for arguments and align frame before entering
// the C++ world.
- AddImmediate(SP, -frame_space);
+ if (frame_space != 0) {
+ AddImmediate(SP, -frame_space);
regis 2013/05/31 16:44:13 On ARM, AddImmediate of 0 to the same register wil
zra 2013/05/31 18:41:17 Done.
+ }
if (OS::ActivationFrameAlignment() > 0) {
LoadImmediate(TMP1, ~(OS::ActivationFrameAlignment() - 1));
and_(SP, SP, TMP1);
@@ -575,7 +579,9 @@
void Assembler::TraceSimMsg(const char* message) {
- // Don't bother adding in the messages unless tracing is enabled.
+ // Don't bother adding in the messages unless tracing is enabled, and we are
+ // running in the simulator.
+#if defined(USING_SIMULATOR)
if (FLAG_trace_sim) {
Label msg;
b(&msg);
@@ -583,6 +589,7 @@
Bind(&msg);
break_(Instr::kMsgMessageCode);
}
+#endif
}
} // namespace dart
« no previous file with comments | « runtime/third_party/double-conversion/src/utils.h ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698