Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 16160010: remove old MakeWeak (Closed)

Created:
7 years, 6 months ago by dcarney
Modified:
6 years, 5 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -112 lines) Patch
M include/v8.h View 5 chunks +2 lines, -25 lines 0 comments Download
M src/api.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/debug.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug.cc View 5 chunks +4 lines, -7 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/global-handles.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/global-handles.cc View 9 chunks +13 lines, -35 lines 0 comments Download
M src/handles.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/profile-generator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profile-generator.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 4 chunks +9 lines, -18 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcarney
we have no deprecation option with this one, it must simply be deleted
7 years, 6 months ago (2013-05-29 16:45:35 UTC) #1
Sven Panne
lgtm
7 years, 6 months ago (2013-06-03 07:35:42 UTC) #2
dcarney
Committed patchset #1 manually as r14911 (presubmit successful).
7 years, 6 months ago (2013-06-03 08:17:16 UTC) #3
jacobsa
6 years, 5 months ago (2014-07-01 00:12:46 UTC) #4
Message was sent while issue was closed.
I'm looking at this code review because I own a project that embeds v8 (Google
JS Test) and am trying to figure out how the hell I make it build with the
latest version of v8 on my system, puzzling through at least three different
backwards-incompatible API changes. This is a real pain in the ass to have to
do every few months.

The last one for me to figure out is MakeWeak, so I'm digging through 'git
blame' to try to infer what I should be using instead. And I land on this code
review thread, which has no context whatsoever -- "remove old MakeWeak" is not
helpful to me in this code archaeology.

You guys could make this a lot easier on people like me if for each
backwards-incompatible API change you wrote up a short document saying:

* What is being deleted.
* Why it is being deleted.
* What users of the deleted API should switch to.
* (Optionally) some before and after sample code.

and then published such documents somewhere central, and linked to them as
context for each change like this one.

Powered by Google App Engine
This is Rietveld 408576698