scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json - Issue 1615963005: [Findit] Refactoring compile recipe return results into report dict instead of list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json

Issue 1615963005: [Findit] Refactoring compile recipe return results into report dict instead of list (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Addressing comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipes/findit/chromium/compile.py ('K') | « scripts/slave/recipes/findit/chromium/compile.expected/compile_default_targets.json ('k') | scripts/slave/recipes/findit/chromium/compile.expected/compile_skipped.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json

diff --git a/scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json b/scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json

index 31182980bf2d3f83c21311b9b8c82aceebb07d36..11b171ea6fa7b69c3c48c6e005d3e090a951a359 100644

--- a/scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json

+++ b/scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json

@@ -404,14 +404,16 @@

"name": "report",

"~followup_annotations": [

"@@@STEP_TEXT@<br/>Culprit: r1@@@",

- "@@@STEP_LOG_LINE@result@[@@@",

- "@@@STEP_LOG_LINE@result@ [@@@",

- "@@@STEP_LOG_LINE@result@ \"r1\", @@@",

- "@@@STEP_LOG_LINE@result@ \"failed\"@@@",

- "@@@STEP_LOG_LINE@result@ ]@@@",

- "@@@STEP_LOG_LINE@result@]@@@",

+ "@@@STEP_LOG_LINE@result@{@@@",

+ "@@@STEP_LOG_LINE@result@ \"result\": {@@@",

+ "@@@STEP_LOG_LINE@result@ \"r1\": \"failed\"@@@",

+ "@@@STEP_LOG_LINE@result@ }, @@@",

+ "@@@STEP_LOG_LINE@result@ \"metadata\": {@@@",

+ "@@@STEP_LOG_LINE@result@ \"regression_range_size\": 1@@@",

+ "@@@STEP_LOG_LINE@result@ }@@@",

+ "@@@STEP_LOG_LINE@result@}@@@",

"@@@STEP_LOG_END@result@@@",

- "@@@SET_BUILD_PROPERTY@result@[[\"r1\", \"failed\"]]@@@"

+ "@@@SET_BUILD_PROPERTY@result@{\"metadata\": {\"regression_range_size\": 1}, \"result\": {\"r1\": \"failed\"}}@@@"

]

{