Fix spellchecker updating of marker ranges spanning multiple elements.

Fix spellchecker updating of marker ranges spanning multiple elements.

The optimization made in Blink r187820 (https://crrev.com/828293002)
completely failed to take into account the case where the start and
end position spanned multiple nodes.

With EphemeralRange since then introduced, fix by switching to it.
For the original test optimized for (blink_perf.dom:textarea-edit),
local testing with chrome-release shows no degradation in performance
either.

R=yosin
BUG=579151
Committed: https://crrev.com/4f439fec8efeead547ab50f0b8824f5fe2fc2f67
Cr-Commit-Position: refs/heads/master@{#370929}

[sof, 2016-01-21 20:57:15]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 20:58:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615963004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615963004/1

[sof, 2016-01-21 21:53:14]

sigbjornf@opera.com changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[sof, 2016-01-21 21:53:14]

please take a look.

The expected outputs for editing/inserting/insert-div-018.html and
editing/deleting/delete-to-select-table.html needs to be updated/adjusted
following this change.

[commit-bot: I haz the power, 2016-01-21 22:15:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 22:15:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yosin_UTC9, 2016-01-22 00:56:15]

Description was changed from

==========
Fix spellchecker updating of marker ranges spanning multiple elements.

The optimization made in Blink r187820 (https://crrev.com/82893002)
completely failed to take into account the case where the start and
end position spanned multiple nodes.

With EphemeralRange since then introduced, fix by switching to it.
For the original test optimized for (blink_perf.dom:textarea-edit),
local testing with chrome-release shows no degradation in performance
either.

R=
BUG=579151
==========

to

==========
Fix spellchecker updating of marker ranges spanning multiple elements.

The optimization made in Blink r187820 (https://crrev.com/828293002)
completely failed to take into account the case where the start and
end position spanned multiple nodes.

With EphemeralRange since then introduced, fix by switching to it.
For the original test optimized for (blink_perf.dom:textarea-edit),
local testing with chrome-release shows no degradation in performance
either.

R=
BUG=579151
==========

[yosin_UTC9, 2016-01-22 01:03:49]

lgtm

Thanks for fixing! It is interesting that |endNode| is disappeared. I guess
since original change
was made of start of new year. We may don't think "end". :-)

P.S.
I fixed crrev link in a description, it missed one digit "0".

P.S.^2
It seems original change was taken place on January 2. In Japan, Jan 1 to Jan 3
are declared as national holiday and most of activities are stopped for
celebrating new year, e.g. no ignition in
kitchen.

[yosin_UTC9, 2016-01-22 01:03:51]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-01-22 01:05:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615963004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615963004/1

[commit-bot: I haz the power, 2016-01-22 02:23:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 02:23:01]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yosin_UTC9, 2016-01-22 04:23:35]

On 2016/01/22 at 02:23:01, commit-bot wrote:
> Try jobs failed on following builders:
>   win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

It seems we need to rebase following tests:
- editing/deleting/delete-to-select-table.html
- editing/inserting/insert-div-018.html

[sof, 2016-01-22 06:45:53]

On 2016/01/22 04:23:35, Yosi_UTC9 wrote:
> On 2016/01/22 at 02:23:01, commit-bot wrote:
> > Try jobs failed on following builders:
> >   win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
> 
> It seems we need to rebase following tests:
> - editing/deleting/delete-to-select-table.html
> - editing/inserting/insert-div-018.html

Yes, thanks - i'll add rebaselines for those and verify.

(Jan 2 is when we've had enough of public holidays in Norway, and just want to
get back to work&school again. Judging by the regression introduced by that CL,
it would have been better to have taken another day off, I reckon :) )

[sof, 2016-01-22 07:39:46]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-22 07:39:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615963004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615963004/20001

[sof, 2016-01-22 07:48:14]

Description was changed from

==========
Fix spellchecker updating of marker ranges spanning multiple elements.

The optimization made in Blink r187820 (https://crrev.com/828293002)
completely failed to take into account the case where the start and
end position spanned multiple nodes.

With EphemeralRange since then introduced, fix by switching to it.
For the original test optimized for (blink_perf.dom:textarea-edit),
local testing with chrome-release shows no degradation in performance
either.

R=
BUG=579151
==========

to

==========
Fix spellchecker updating of marker ranges spanning multiple elements.

The optimization made in Blink r187820 (https://crrev.com/828293002)
completely failed to take into account the case where the start and
end position spanned multiple nodes.

With EphemeralRange since then introduced, fix by switching to it.
For the original test optimized for (blink_perf.dom:textarea-edit),
local testing with chrome-release shows no degradation in performance
either.

R=yosin
BUG=579151
==========

[commit-bot: I haz the power, 2016-01-22 09:03:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 09:03:39]

Dry run: This issue passed the CQ dry run.

[sof, 2016-01-22 09:14:21]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2016-01-22 09:14:21]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1615963004/#ps20001
(title: "Add reqd rebaseline entries")

[commit-bot: I haz the power, 2016-01-22 09:14:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615963004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615963004/20001

[commit-bot: I haz the power, 2016-01-22 09:19:18]

Description was changed from

==========
Fix spellchecker updating of marker ranges spanning multiple elements.

The optimization made in Blink r187820 (https://crrev.com/828293002)
completely failed to take into account the case where the start and
end position spanned multiple nodes.

With EphemeralRange since then introduced, fix by switching to it.
For the original test optimized for (blink_perf.dom:textarea-edit),
local testing with chrome-release shows no degradation in performance
either.

R=yosin
BUG=579151
==========

to

==========
Fix spellchecker updating of marker ranges spanning multiple elements.

The optimization made in Blink r187820 (https://crrev.com/828293002)
completely failed to take into account the case where the start and
end position spanned multiple nodes.

With EphemeralRange since then introduced, fix by switching to it.
For the original test optimized for (blink_perf.dom:textarea-edit),
local testing with chrome-release shows no degradation in performance
either.

R=yosin
BUG=579151
==========

[commit-bot: I haz the power, 2016-01-22 09:19:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-22 09:20:15]

Description was changed from

==========
Fix spellchecker updating of marker ranges spanning multiple elements.

The optimization made in Blink r187820 (https://crrev.com/828293002)
completely failed to take into account the case where the start and
end position spanned multiple nodes.

With EphemeralRange since then introduced, fix by switching to it.
For the original test optimized for (blink_perf.dom:textarea-edit),
local testing with chrome-release shows no degradation in performance
either.

R=yosin
BUG=579151
==========

to

==========
Fix spellchecker updating of marker ranges spanning multiple elements.

The optimization made in Blink r187820 (https://crrev.com/828293002)
completely failed to take into account the case where the start and
end position spanned multiple nodes.

With EphemeralRange since then introduced, fix by switching to it.
For the original test optimized for (blink_perf.dom:textarea-edit),
local testing with chrome-release shows no degradation in performance
either.

R=yosin
BUG=579151

Committed: https://crrev.com/4f439fec8efeead547ab50f0b8824f5fe2fc2f67
Cr-Commit-Position: refs/heads/master@{#370929}
==========

[commit-bot: I haz the power, 2016-01-22 09:20:16]

Patchset 2 (id:??) landed as
https://crrev.com/4f439fec8efeead547ab50f0b8824f5fe2fc2f67
Cr-Commit-Position: refs/heads/master@{#370929}