Issue 25522. Insert a synthetic '>' for incomplete type arguments.

Issue 25522. Insert a synthetic '>' for incomplete type arguments.

If we don't do this and insert 'f' instead, later when we attempt to
search 'f' by its offset we find the type instead of the identifier 'f'.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25522

Committed: https://github.com/dart-lang/sdk/commit/b78decfa8fbe36e73a1e4afec880d393acaec947

[Brian Wilkerson, 2016-01-21 19:25:12]

LGTM

https://codereview.chromium.org/1615963003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/parser.dart (right):

https://codereview.chromium.org/1615963003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/parser.dart:3804: * to the next token. Otherwise
report an error and return the current token
The comment needs to be updated.

https://codereview.chromium.org/1615963003/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/parser_test.dart (right):

https://codereview.chromium.org/1615963003/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/parser_test.dart:3713: void
test_incompleteParameterizedType_field() {
The method _expectGT is also used for type parameters, so we might want to add a
test for that case as well.

[scheglov, 2016-01-21 21:03:27]

Description was changed from

==========
Issue 25522. Insert a synthetic '>' for incomplete type arguments.

If we don't do this and insert 'f' instead, later when we attempt to
search 'f' by its offset we find the type instead of the identifier 'f'.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25522
==========

to

==========
Issue 25522. Insert a synthetic '>' for incomplete type arguments.

If we don't do this and insert 'f' instead, later when we attempt to
search 'f' by its offset we find the type instead of the identifier 'f'.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25522

Committed:
https://github.com/dart-lang/sdk/commit/b78decfa8fbe36e73a1e4afec880d393acaec947
==========

[scheglov, 2016-01-21 21:03:28]

Committed patchset #1 (id:1) manually as
b78decfa8fbe36e73a1e4afec880d393acaec947 (presubmit successful).

[scheglov, 2016-01-21 21:03:47]

https://codereview.chromium.org/1615963003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/parser.dart (right):

https://codereview.chromium.org/1615963003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/parser.dart:3804: * to the next token. Otherwise
report an error and return the current token
On 2016/01/21 19:25:12, Brian Wilkerson wrote:
> The comment needs to be updated.

Done.

https://codereview.chromium.org/1615963003/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/parser_test.dart (right):

https://codereview.chromium.org/1615963003/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/parser_test.dart:3713: void
test_incompleteParameterizedType_field() {
On 2016/01/21 19:25:12, Brian Wilkerson wrote:
> The method _expectGT is also used for type parameters, so we might want to add
a
> test for that case as well.

Done.