Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 1615943002: Runtime call counters and timers. (Closed)

Created:
4 years, 11 months ago by Jarin
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Runtime call counters and timers. In d8, run with --runtime-call-stats and it will output the stats when d8 finishes. In Chrome, run the following: (only on trusted code, this punches *massive* security hole into Chrome) chrome --js-flags="--runtime-call-stats --allow-natives-syntax" To get the stats in the console, just run console.log(%GetAndResetRuntimeCallStats()); To output stats every second: setInterval(function() { console.log(%GetAndResetRuntimeCallStats()); }, 1000) Committed: https://crrev.com/747bd6f2150134196b7b95c89320a15eeefc5263 Cr-Commit-Position: refs/heads/master@{#33462}

Patch Set 1 #

Patch Set 2 : Use manipulators #

Patch Set 3 : Fix #

Patch Set 4 : Attempt to fix win #

Patch Set 5 : Another attempt #

Patch Set 6 : Attempt 3 #

Patch Set 7 : Attempt 4 #

Patch Set 8 : Runtime function for getting the stats #

Total comments: 1

Patch Set 9 : Tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+458 lines, -314 lines) Patch
M src/arguments.h View 1 2 3 4 5 6 7 8 1 chunk +23 lines, -8 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 2 3 4 5 6 7 5 chunks +338 lines, -306 lines 0 comments Download
M src/runtime/runtime.cc View 1 2 3 4 5 6 7 2 chunks +77 lines, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 2 3 4 5 6 7 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
Nice. LGTM with comment. https://codereview.chromium.org/1615943002/diff/140001/src/arguments.h File src/arguments.h (right): https://codereview.chromium.org/1615943002/diff/140001/src/arguments.h#newcode290 src/arguments.h:290: if (FLAG_runtime_call_stats && timing) { ...
4 years, 11 months ago (2016-01-22 09:41:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615943002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615943002/160001
4 years, 11 months ago (2016-01-22 09:53:09 UTC) #6
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 11 months ago (2016-01-22 10:11:14 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 10:12:16 UTC) #10
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/747bd6f2150134196b7b95c89320a15eeefc5263
Cr-Commit-Position: refs/heads/master@{#33462}

Powered by Google App Engine
This is Rietveld 408576698