Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1615903002: [debugger] muting break positions should work for the entire statement. (Closed)

Created:
4 years, 11 months ago by Yang
Modified:
4 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] muting break positions should work for the entire statement. A statement could have several break positions. The entire statement should be considered muted if break points across all these break positions evaluate to false. R=verwaest@chromium.org BUG=chromium:429167 LOG=N Committed: https://crrev.com/8349ee0c269d527d1d1c6f11a685ee4ee221720d Cr-Commit-Position: refs/heads/master@{#33522}

Patch Set 1 #

Patch Set 2 : adapt comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -9 lines) Patch
M src/debug/debug.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/debug/debug.cc View 1 3 chunks +30 lines, -9 lines 0 comments Download
M test/mjsunit/debug-negative-break-points.js View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Yang
Toon, please review. I had to change this to meet Devtools' expectation.
4 years, 11 months ago (2016-01-21 14:42:22 UTC) #1
Yang
On 2016/01/21 14:42:22, Yang wrote: > Toon, please review. > > I had to change ...
4 years, 11 months ago (2016-01-22 18:29:08 UTC) #2
Yang
On 2016/01/22 18:29:08, Yang wrote: > On 2016/01/21 14:42:22, Yang wrote: > > Toon, please ...
4 years, 11 months ago (2016-01-25 14:16:14 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615903002/20001
4 years, 11 months ago (2016-01-26 12:16:22 UTC) #5
Yang
On 2016/01/25 14:16:14, Yang wrote: > On 2016/01/22 18:29:08, Yang wrote: > > On 2016/01/21 ...
4 years, 11 months ago (2016-01-26 12:16:29 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-26 12:43:05 UTC) #8
Toon Verwaest
lgtm
4 years, 11 months ago (2016-01-26 13:09:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615903002/20001
4 years, 10 months ago (2016-01-26 14:57:09 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-26 15:04:52 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-01-26 15:05:16 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8349ee0c269d527d1d1c6f11a685ee4ee221720d
Cr-Commit-Position: refs/heads/master@{#33522}

Powered by Google App Engine
This is Rietveld 408576698