Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1615823003: Set LSMinimumSystemVersion to 10.9.0 (Closed)

Created:
4 years, 11 months ago by Mark Mentovai
Modified:
4 years, 9 months ago
Reviewers:
tapted, erikchen, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set LSMinimumSystemVersion to 10.9.0 Normally, this would be handled by setting the deployment target to 10.9 (bug 579255) but we’re not ready for that yet. This is a temporary hard-code to 10.9 in the Info.plist. BUG=569584 Committed: https://crrev.com/65ce38ab6c9ad47d5cdcf096f118282891b6aebe Cr-Commit-Position: refs/heads/master@{#378851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/app/app-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/helper-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app_shim/app_mode-Info.plist View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (10 generated)
Mark Mentovai
4 years, 11 months ago (2016-01-21 22:42:44 UTC) #2
tapted
lgtm - guess that means there's no point me checking that `mac_chromium_10.6_rel_ng` trybot any more ...
4 years, 11 months ago (2016-01-21 23:06:04 UTC) #3
tapted
(oh, but also there was some doubt raised whether we still had bots we actually ...
4 years, 11 months ago (2016-01-21 23:07:19 UTC) #4
Mark Mentovai
Yeah, I’m sure we’ve got old bots that won’t like this, and this will help ...
4 years, 11 months ago (2016-01-22 00:31:12 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615823003/1
4 years, 9 months ago (2016-02-29 19:02:12 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/175375)
4 years, 9 months ago (2016-02-29 19:09:39 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615823003/1
4 years, 9 months ago (2016-03-02 20:59:49 UTC) #11
erikchen
thakis: Please review chrome/
4 years, 9 months ago (2016-03-02 21:00:38 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615823003/1
4 years, 9 months ago (2016-03-02 21:01:33 UTC) #16
Nico
very lgtm
4 years, 9 months ago (2016-03-02 21:01:46 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 21:46:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615823003/1
4 years, 9 months ago (2016-03-02 21:56:03 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 22:03:45 UTC) #22
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 22:05:22 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65ce38ab6c9ad47d5cdcf096f118282891b6aebe
Cr-Commit-Position: refs/heads/master@{#378851}

Powered by Google App Engine
This is Rietveld 408576698