components/components_resources.gyp - Issue 1615823002: Add missing GYP hard dependency on components resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/components_resources.gyp

Issue 1615823002: Add missing GYP hard dependency on components resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/components_resources.gyp

diff --git a/components/components_resources.gyp b/components/components_resources.gyp

index 9d73e3ddbb65968f65df53aca76a68af51323a5e..40d8b518ff5c64c817c0bc43233360ce07d6acbc 100644

--- a/components/components_resources.gyp

+++ b/components/components_resources.gyp

@@ -45,6 +45,7 @@

# GN version: //components/resources:about_credits

'target_name': 'about_credits',

'type': 'none',

+ 'hard_dependency': 1,

'actions': [

{

'variables': {

@@ -61,7 +62,6 @@

'outputs': [

'<(about_credits_file)',

- 'hard_dependency': 1,

'action': ['python',

'<(generator_path)',

'credits',

« no previous file with comments | « no previous file | components/components_strings.gyp » ('j') | no next file with comments »