Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: components/components_strings.gyp

Issue 1615823002: Add missing GYP hard dependency on components resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/components_resources.gyp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'components_strings', 8 'target_name': 'components_strings',
9 'type': 'none', 9 'type': 'none',
10 'hard_dependency': 1,
10 'variables': { 11 'variables': {
11 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/components/strings', 12 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/components/strings',
12 }, 13 },
13 'actions': [ 14 'actions': [
14 { 15 {
15 # GN version: //components/strings:components_strings 16 # GN version: //components/strings:components_strings
16 'action_name': 'generate_components_strings', 17 'action_name': 'generate_components_strings',
17 'variables': { 18 'variables': {
18 'grit_grd_file': 'components_strings.grd', 19 'grit_grd_file': 'components_strings.grd',
19 }, 20 },
(...skipping 13 matching lines...) Expand all
33 'variables': { 34 'variables': {
34 'grit_grd_file': 'components_google_chrome_strings.grd', 35 'grit_grd_file': 'components_google_chrome_strings.grd',
35 }, 36 },
36 'includes': [ '../build/grit_action.gypi' ], 37 'includes': [ '../build/grit_action.gypi' ],
37 }, 38 },
38 ], 39 ],
39 'includes': [ '../build/grit_target.gypi' ], 40 'includes': [ '../build/grit_target.gypi' ],
40 }, 41 },
41 ], 42 ],
42 } 43 }
OLDNEW
« no previous file with comments | « components/components_resources.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698