Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: components/components_resources.gyp

Issue 1615823002: Add missing GYP hard dependency on components resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/components_strings.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'about_credits_file': '<(SHARED_INTERMEDIATE_DIR)/about_credits.html', 7 'about_credits_file': '<(SHARED_INTERMEDIATE_DIR)/about_credits.html',
8 }, 8 },
9 'targets': [ 9 'targets': [
10 { 10 {
(...skipping 27 matching lines...) Expand all
38 }, 38 },
39 'includes': [ '../build/grit_action.gypi' ], 39 'includes': [ '../build/grit_action.gypi' ],
40 }, 40 },
41 ], 41 ],
42 'includes': [ '../build/grit_target.gypi' ], 42 'includes': [ '../build/grit_target.gypi' ],
43 }, 43 },
44 { 44 {
45 # GN version: //components/resources:about_credits 45 # GN version: //components/resources:about_credits
46 'target_name': 'about_credits', 46 'target_name': 'about_credits',
47 'type': 'none', 47 'type': 'none',
48 'hard_dependency': 1,
48 'actions': [ 49 'actions': [
49 { 50 {
50 'variables': { 51 'variables': {
51 'generator_path': '../tools/licenses.py', 52 'generator_path': '../tools/licenses.py',
52 }, 53 },
53 'action_name': 'generate_about_credits', 54 'action_name': 'generate_about_credits',
54 'inputs': [ 55 'inputs': [
55 # TODO(phajdan.jr): make licenses.py print license input files so 56 # TODO(phajdan.jr): make licenses.py print license input files so
56 # about:credits gets rebuilt when one changes. 57 # about:credits gets rebuilt when one changes.
57 '<(generator_path)', 58 '<(generator_path)',
58 'about_ui/resources/about_credits.tmpl', 59 'about_ui/resources/about_credits.tmpl',
59 'about_ui/resources/about_credits_entry.tmpl', 60 'about_ui/resources/about_credits_entry.tmpl',
60 ], 61 ],
61 'outputs': [ 62 'outputs': [
62 '<(about_credits_file)', 63 '<(about_credits_file)',
63 ], 64 ],
64 'hard_dependency': 1,
65 'action': ['python', 65 'action': ['python',
66 '<(generator_path)', 66 '<(generator_path)',
67 'credits', 67 'credits',
68 '<(about_credits_file)', 68 '<(about_credits_file)',
69 ], 69 ],
70 'message': 'Generating about:credits', 70 'message': 'Generating about:credits',
71 }, 71 },
72 ], 72 ],
73 }, 73 },
74 ], 74 ],
75 } 75 }
OLDNEW
« no previous file with comments | « no previous file | components/components_strings.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698