Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1615823002: Add missing GYP hard dependency on components resources (Closed)

Created:
4 years, 11 months ago by droger
Modified:
4 years, 11 months ago
Reviewers:
blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing GYP hard dependency on components resources BUG=576277 Committed: https://crrev.com/d5b7b50eabc9068a01d55530edeaa9fe483a3ce6 Cr-Commit-Position: refs/heads/master@{#370680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/components_resources.gyp View 2 chunks +1 line, -1 line 0 comments Download
M components/components_strings.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
droger
4 years, 11 months ago (2016-01-21 12:33:16 UTC) #2
blundell
lgtm
4 years, 11 months ago (2016-01-21 12:37:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615823002/1
4 years, 11 months ago (2016-01-21 12:38:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 13:28:14 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 13:29:16 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d5b7b50eabc9068a01d55530edeaa9fe483a3ce6
Cr-Commit-Position: refs/heads/master@{#370680}

Powered by Google App Engine
This is Rietveld 408576698