Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16158007: Make GrGLProgram no longer depend on kNumStages (Closed)

Created:
7 years, 6 months ago by bsalomon
Modified:
7 years, 6 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make GrGLProgram no longer depend on kNumStages R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9462

Patch Set 1 #

Patch Set 2 : lala #

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -41 lines) Patch
M src/gpu/gl/GrGLProgram.h View 1 2 4 chunks +14 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 10 chunks +39 lines, -35 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bsalomon
removes some more references to kNumStages.
7 years, 6 months ago (2013-06-05 20:39:54 UTC) #1
robertphillips
lgtm
7 years, 6 months ago (2013-06-05 20:51:01 UTC) #2
Tom Hudson
UNLIMITED STAGES - UNLIMITED POWER!
7 years, 6 months ago (2013-06-06 09:20:50 UTC) #3
bsalomon
On 2013/06/06 09:20:50, Tom Hudson wrote: > UNLIMITED STAGES - UNLIMITED POWER! :)
7 years, 6 months ago (2013-06-06 12:48:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/16158007/8001
7 years, 6 months ago (2013-06-06 12:48:29 UTC) #5
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildGM http://108.170.217.252:10117/buildstatus?builder=Build-Mac10.7-Clang-x86-Release-Trybot&number=87
7 years, 6 months ago (2013-06-06 13:00:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/16158007/8001
7 years, 6 months ago (2013-06-06 16:03:15 UTC) #7
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildGM http://108.170.217.252:10117/buildstatus?builder=Build-Mac10.7-Clang-x86-Release-Trybot&number=90
7 years, 6 months ago (2013-06-06 16:19:46 UTC) #8
bsalomon
7 years, 6 months ago (2013-06-06 18:04:52 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 manually as r9462 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698