Adds CreateSelfSignedCertEC to x509_util.h in preparation of persistent DTLS identity store for Web…

net/cert/x509_util_nss.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/x509_util.h"
 #include "net/cert/x509_util_nss.h"
 
 #include <cert.h>  // Must be included before certdb.h
 #include <certdb.h>
 #include <cryptohi.h>
@@ skipping 347 matching lines @@
   DCHECK(key);
   return CreateDomainBoundCertInternal(key->public_key(),
                                        key->key(),
                                        domain,
                                        serial_number,
                                        not_valid_before,
                                        not_valid_after,
                                        der_cert);
 }
 
+bool CreateSelfSignedCertEC(
+    crypto::ECPrivateKey* key,
+    const std::string& subject,
+    uint32 serial_number,
+    base::Time not_valid_before,
+    base::Time not_valid_after,
+    std::string* der_cert) {
+  DCHECK(key);

[Ryan Sleevi, 2013/06/06 23:26:15]

DESIGN: You probably want to be looking at IsSupportedValidityRange() to make
sure your callers are supplying valid validity periods.

[jiayl, 2013/06/06 23:45:37]

CreateCertificate already checks range validity and returns NULL cert if not
valid.

+  CERTCertificate* cert = CreateSelfSignedCert(key->public_key(),
+                                               key->key(),
+                                               subject,
+                                               serial_number,
+                                               not_valid_before,
+                                               not_valid_after);
+  if (!cert)
+    return false;
+  der_cert->assign(reinterpret_cast<char*>(cert->derCert.data),
+                   cert->derCert.len);
+  CERT_DestroyCertificate(cert);
+  cert = NULL;

[Ryan Sleevi, 2013/06/06 23:26:15]

There's no need for this "= NULL"

[jiayl, 2013/06/06 23:45:37]

Done.

+
+  return true;
+}
+
 #if defined(USE_NSS) || defined(OS_IOS)
 void ParsePrincipal(CERTName* name, CertPrincipal* principal) {
 // Starting in NSS 3.15, CERTGetNameFunc takes a const CERTName* argument.
 #if NSS_VMINOR >= 15
   typedef char* (*CERTGetNameFunc)(const CERTName* name);
 #else
   typedef char* (*CERTGetNameFunc)(CERTName* name);
 #endif
 
   // TODO(jcampan): add business_category and serial_number.
@@ skipping 248 matching lines @@
   }
 
   return new_name;
 }
 
 #endif  // defined(USE_NSS) || defined(OS_IOS)
 
 } // namespace x509_util
 
 } // namespace net