Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Unified Diff: net/cookies/cookie_options.h

Issue 1615773005: Rename first-party-only cookies to same-site cookies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tests. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/cookie_monster_unittest.cc ('k') | net/cookies/cookie_options.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_options.h
diff --git a/net/cookies/cookie_options.h b/net/cookies/cookie_options.h
index 4d2a774c1bcc723c46d9906cfc2c0b068b44f0f8..25dedb14e19048b3314136449fb7c04f206f79a5 100644
--- a/net/cookies/cookie_options.h
+++ b/net/cookies/cookie_options.h
@@ -18,13 +18,13 @@ class NET_EXPORT CookieOptions {
// Creates a CookieOptions object which:
//
// * Excludes HttpOnly cookies
- // * Excludes First-Party-Only cookies
+ // * Excludes SameSite cookies
// * Does not enforce prefix restrictions (e.g. "$Secure-*")
//
// These settings can be altered by calling:
//
// * |set_{include,exclude}_httponly()|
- // * |set_include_first_party_only_cookies()|
+ // * |set_include_same_site()|
// * |set_enforce_prefixes()|
CookieOptions();
@@ -32,13 +32,9 @@ class NET_EXPORT CookieOptions {
void set_include_httponly() { exclude_httponly_ = false; }
bool exclude_httponly() const { return exclude_httponly_; }
- // Default is to exclude 'first-party-only' cookies.
- void set_include_first_party_only_cookies() {
- include_first_party_only_cookies_ = true;
- }
- bool include_first_party_only_cookies() const {
- return include_first_party_only_cookies_;
- }
+ // Default is to exclude 'same_site' cookies.
+ void set_include_same_site() { include_same_site_ = true; }
+ bool include_same_site() const { return include_same_site_; }
// TODO(jww): Remove once we decide whether to ship modifying 'secure' cookies
// only from secure schemes. https://crbug.com/546820
@@ -56,7 +52,7 @@ class NET_EXPORT CookieOptions {
private:
bool exclude_httponly_;
- bool include_first_party_only_cookies_;
+ bool include_same_site_;
bool enforce_strict_secure_;
base::Time server_time_;
};
« no previous file with comments | « net/cookies/cookie_monster_unittest.cc ('k') | net/cookies/cookie_options.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698