chrome/browser/browsing_data/cookies_tree_model.cc - Issue 1615773005: Rename first-party-only cookies to same-site cookies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/cookies_tree_model.cc

Issue 1615773005: Rename first-party-only cookies to same-site cookies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missed a few. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/cookies/cookies_fetcher.cc ('K') | « chrome/browser/android/cookies/cookies_fetcher.cc ('k') | chrome/browser/net/chrome_network_delegate_unittest.cc » ('j') | ios/net/cookies/cookie_store_ios_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/cookies_tree_model.cc

diff --git a/chrome/browser/browsing_data/cookies_tree_model.cc b/chrome/browser/browsing_data/cookies_tree_model.cc

index 57e001def8fd8bee1a5573c8493528ca81c5d8e1..1800b1746119b2a2d15fa3998f69e9a44189c647 100644

--- a/chrome/browser/browsing_data/cookies_tree_model.cc

+++ b/chrome/browser/browsing_data/cookies_tree_model.cc

@@ -992,12 +992,12 @@ CookiesTreeModel::~CookiesTreeModel() {

// static

int CookiesTreeModel::GetSendForMessageID(const net::CanonicalCookie& cookie) {

if (cookie.IsSecure()) {

- if (cookie.IsFirstPartyOnly())

- return IDS_COOKIES_COOKIE_SENDFOR_SECURE_FIRSTPARTY;

+ if (cookie.IsSameSite())

+ return IDS_COOKIES_COOKIE_SENDFOR_SECURE_SAMESITE;

return IDS_COOKIES_COOKIE_SENDFOR_SECURE;

}

- if (cookie.IsFirstPartyOnly())

- return IDS_COOKIES_COOKIE_SENDFOR_FIRSTPARTY;

+ if (cookie.IsSameSite())

+ return IDS_COOKIES_COOKIE_SENDFOR_SAMESITE;

return IDS_COOKIES_COOKIE_SENDFOR_ANY;

}