Fix an assert failure in CXFA_DefFontMgr::GetDefaultFont()

Fix an assert failure in CXFA_DefFontMgr::GetDefaultFont()

Font information (like size) is needed to perform layout
in the process of loading XFA documents. It was too late
to set g_last_instance_id so that XFA didn't get a font
by calling FontMap().

BUG=pdfium:349
Committed: https://crrev.com/1a4c0307e48e24aa1c36b990976e66b0c514dfd9
Cr-Commit-Position: refs/heads/master@{#372196}

[jun_fang, 2016-01-21 11:25:37]

Description was changed from

==========
Fix an assert failure in CXFA_DefFontMgr::GetDefaultFont()

BUG=pdfium:349
==========

to

==========
Fix an assert failure in CXFA_DefFontMgr::GetDefaultFont()

Font information (like size) is needed to perform layout 
in the process of loading XFA documents. It was too late
to set g_last_instance_id so that XFA didn't get a font 
by calling FontMap().

BUG=pdfium:349
==========

[jun_fang, 2016-01-21 11:25:38]

jun_fang@foxitsoftware.com changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[Tom Sepez, 2016-01-21 16:50:59]

tsepez@chromium.org changed reviewers:
+ raymes@chromium.org

[Tom Sepez, 2016-01-21 16:51:34]

On 2016/01/21 16:50:59, Tom Sepez wrote:
> mailto:tsepez@chromium.org changed reviewers:
> + mailto:raymes@chromium.org

+raymes instead of the OOO 'stig, maybe?

[Tom Sepez, 2016-01-21 16:51:55]

https://codereview.chromium.org/1615723003/diff/1/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/1615723003/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:611: g_last_instance_id =
client_->GetPluginInstance()->pp_instance();
Why is this linux only?

[jun_fang, 2016-01-22 00:16:25]

On 2016/01/21 16:51:55, Tom Sepez wrote:
> https://codereview.chromium.org/1615723003/diff/1/pdf/pdfium/pdfium_engine.cc
> File pdf/pdfium/pdfium_engine.cc (right):
> 
>
https://codereview.chromium.org/1615723003/diff/1/pdf/pdfium/pdfium_engine.cc...
> pdf/pdfium/pdfium_engine.cc:611: g_last_instance_id =
> client_->GetPluginInstance()->pp_instance();
> Why is this linux only?


You can check g_last_instance_id in pdf/pdfium/pdfium_engine.cc. 
It was defined only when OS_LINUX was defined.

#if defined(OS_LINUX)

PP_Instance g_last_instance_id;

[raymes, 2016-01-22 01:40:59]

This seems ok. lgtm

[Tom Sepez, 2016-01-22 02:09:52]

lgtm

[jun_fang, 2016-01-22 03:03:17]

On 2016/01/22 02:09:52, Tom Sepez wrote:
> lgtm

When I tried to land this patch, the landing process always
stopped at:

"Fetching pending ref refs/pending/heads/master..."
 
Maybe I don't have the permission to land code changes in this directory. 
Can you land this patch for me? Thanks!

[Tom Sepez, 2016-01-22 17:00:07]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-01-22 17:00:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615723003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615723003/1

[commit-bot: I haz the power, 2016-01-22 17:00:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 17:00:22]

The author jun_fang@foxitsoftware.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[Tom Sepez, 2016-01-22 17:02:13]

The best way to land changes to chromium itself is to check the "commit" box
above, if you are a chromium committer. Otherwise, ping me and I'll check it for
you as I've just done.  Thanks!

[Tom Sepez, 2016-01-22 17:04:59]

Bleh.  You should be covered by the FX agreement, lemme check.

[jun_fang, 2016-01-24 12:52:47]

On 2016/01/22 17:04:59, Tom Sepez wrote:
> Bleh.  You should be covered by the FX agreement, lemme check.

I was unable to land it after I signed at https://cla.developers.google.com.

[jun_fang, 2016-01-24 12:53:10]

The CQ bit was checked by jun_fang@foxitsoftware.com

[jun_fang, 2016-01-24 12:53:10]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/1615723003/#ps20001
(title: "Rebase")

[jun_fang, 2016-01-24 12:53:15]

The CQ bit was unchecked by jun_fang@foxitsoftware.com

[jun_fang, 2016-01-26 11:57:50]

On 2016/01/24 12:52:47, jun_fang wrote:
> On 2016/01/22 17:04:59, Tom Sepez wrote:
> > Bleh.  You should be covered by the FX agreement, lemme check.
> 
> I was unable to land it after I signed at https://cla.developers.google.com.

Hi Lei,

Please help to land this patch for me. Thanks!

[Lei Zhang, 2016-01-26 22:20:43]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-01-26 22:22:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615723003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615723003/20001

[Lei Zhang, 2016-01-26 22:29:08]

On 2016/01/26 11:57:50, jun_fang wrote:
> On 2016/01/24 12:52:47, jun_fang wrote:
> > On 2016/01/22 17:04:59, Tom Sepez wrote:
> > > Bleh.  You should be covered by the FX agreement, lemme check.
> > 
> > I was unable to land it after I signed at https://cla.developers.google.com.
> 
> Hi Lei,
> 
> Please help to land this patch for me. Thanks!

You need to add yourself to the AUTHORS file.

[commit-bot: I haz the power, 2016-01-26 22:36:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 22:36:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Lei Zhang, 2016-01-28 21:47:25]

On 2016/01/26 22:29:08, Lei Zhang wrote:
> You need to add yourself to the AUTHORS file.

BTW, you could have done that in this CL, but I see you used a separate CL:
https://codereview.chromium.org/1648623002/

With that landed, I'll put this in CQ again.

[Lei Zhang, 2016-01-28 21:47:30]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-01-28 21:48:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615723003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615723003/20001

[commit-bot: I haz the power, 2016-01-28 22:49:01]

Description was changed from

==========
Fix an assert failure in CXFA_DefFontMgr::GetDefaultFont()

Font information (like size) is needed to perform layout 
in the process of loading XFA documents. It was too late
to set g_last_instance_id so that XFA didn't get a font 
by calling FontMap().

BUG=pdfium:349
==========

to

==========
Fix an assert failure in CXFA_DefFontMgr::GetDefaultFont()

Font information (like size) is needed to perform layout 
in the process of loading XFA documents. It was too late
to set g_last_instance_id so that XFA didn't get a font 
by calling FontMap().

BUG=pdfium:349
==========

[commit-bot: I haz the power, 2016-01-28 22:49:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-28 22:50:35]

Description was changed from

==========
Fix an assert failure in CXFA_DefFontMgr::GetDefaultFont()

Font information (like size) is needed to perform layout 
in the process of loading XFA documents. It was too late
to set g_last_instance_id so that XFA didn't get a font 
by calling FontMap().

BUG=pdfium:349
==========

to

==========
Fix an assert failure in CXFA_DefFontMgr::GetDefaultFont()

Font information (like size) is needed to perform layout
in the process of loading XFA documents. It was too late
to set g_last_instance_id so that XFA didn't get a font
by calling FontMap().

BUG=pdfium:349

Committed: https://crrev.com/1a4c0307e48e24aa1c36b990976e66b0c514dfd9
Cr-Commit-Position: refs/heads/master@{#372196}
==========

[commit-bot: I haz the power, 2016-01-28 22:50:36]

Patchset 2 (id:??) landed as
https://crrev.com/1a4c0307e48e24aa1c36b990976e66b0c514dfd9
Cr-Commit-Position: refs/heads/master@{#372196}

[jun_fang, 2016-02-23 05:55:09]

Patchset #3 (id:40001) has been deleted