Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1499)

Issue 1615713003: Allow std::unordered_*. (Closed)

Created:
4 years, 11 months ago by davidben
Modified:
4 years, 11 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, vmpstr+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, tzik, jam, jbroman+cpp_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, tdresser+watch_chromium.org, derat+watch_chromium.org, ozone-reviews_chromium.org, nhiroki, rlp+watch_chromium.org, feature-media-reviews_chromium.org, rouslan+spell_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, rjkroege, pfeldman, cc-bugs_chromium.org, kinuko+fileapi, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow std::unordered_*. This is a reland of https://codereview.chromium.org/1502373009 with some fixes for components/metrics/leak_detector allocator type mismatches. Original issue's description: > Allow std::unordered_*. > > base::hash_* is, as a transition step, implemented in terms of > std::unordered_*. Later commits will convert existing uses. > > Also fix a host of IWYU problems that arose from this CL. > > (NOPRESUBMIT because the wstring presubmit check is overzealous > and complains about the reference to wstring in the comment.) > > Committed: https://crrev.com/3f37f7f1459e7b5a452c0e433493e0a6e9649ca7 > Cr-Commit-Position: refs/heads/master@{#370553} BUG=576864 TBR=derat@chromium.org,danakj@chromium.org,dalecurtis@chromium.org,jbauman@chromium.org,blundell@chromium.org NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/411d3f7a3a18335713a46d9022ce25e018a19e47 Cr-Commit-Position: refs/heads/master@{#370867}

Patch Set 1 : original version #

Patch Set 2 : leak_detector fixes and git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -321 lines) Patch
M ash/display/display_info.cc View 1 chunk +4 lines, -1 line 0 comments Download
M base/containers/hash_tables.h View 1 1 chunk +37 lines, -243 lines 0 comments Download
M base/containers/scoped_ptr_hash_map.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/hash.h View 1 2 chunks +82 lines, -0 lines 0 comments Download
M base/location.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/strings/string16.h View 1 2 chunks +17 lines, -0 lines 0 comments Download
M base/strings/string16_unittest.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M base/strings/string_piece.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/debug/picture_debug_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M cc/quads/render_pass.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/quads/render_pass_id.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/quads/render_pass_id.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M cc/surfaces/surface_sequence.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/tiles/image_decode_controller.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/devtools/devtools_file_watcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/log_private/filter_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/google/google_brand.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_host_metrics.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/task_management/providers/web_contents/web_contents_tags_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/favicon_base/favicon_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/leak_detector/call_stack_table.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/leak_detector/leak_detector_impl.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M components/mus/ws/display_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_bookmarks/bookmark_model_associator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/framebuffer_completeness_cache.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/blink/multibuffer.h View 2 chunks +2 lines, -9 lines 0 comments Download
M net/base/network_change_notifier_linux.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/port_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/simple/simple_index_file.cc View 1 chunk +1 line, -4 lines 0 comments Download
M net/server/web_socket_encoder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/ssl/client_cert_store_nss.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_session_base_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M styleguide/c++/c++11.html View 4 chunks +22 lines, -22 lines 0 comments Download
M ui/base/x/selection_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/generic_shared_memory_id.h View 2 chunks +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (11 generated)
davidben
thakis and sque for general review of components/metrics/leak_detector. Otherwise the CL is the same as ...
4 years, 11 months ago (2016-01-21 22:16:47 UTC) #3
Nico
lgtm
4 years, 11 months ago (2016-01-21 22:19:23 UTC) #5
danakj
(You could just reopen the old CL then it will have all the comments and ...
4 years, 11 months ago (2016-01-21 22:20:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615713003/20001
4 years, 11 months ago (2016-01-21 22:35:11 UTC) #8
davidben
On 2016/01/21 22:35:11, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 11 months ago (2016-01-21 22:37:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615713003/20001
4 years, 11 months ago (2016-01-21 22:40:02 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/114452)
4 years, 11 months ago (2016-01-22 00:08:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615713003/20001
4 years, 11 months ago (2016-01-22 00:12:19 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 01:41:52 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 01:43:39 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/411d3f7a3a18335713a46d9022ce25e018a19e47
Cr-Commit-Position: refs/heads/master@{#370867}

Powered by Google App Engine
This is Rietveld 408576698